Improved path handling, reported filenames are converted to src dir relative paths #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stub parser is not used anymore, removed it
Justification: relying on getParentFile gets the path splitting working under windows and unix - adapted the tests to the new behavior - added a windows / unix switch in the tests to get them working on both systems PathUtils now converts: - the empty path to an empty List - an absolute path to a list folders (not including the drive name under windows) - a relative path to a list of folders
Justification:
- sanitizing the reported file pathes to a common format makes the sensor simpler
- it is a precondition for implementing proper directory coverage
- tests run now under unix and windows, easier to develop
The sonar.sources property can be read from the settings. By mapping all
reported pathes (absolute / base dir relative / source dir relative) against
the actual file tree it is possible to converte all of them to the same
source dir relative format.
For instance
/home/src/main/scala/folder/test0.scala => folder/test0.scala
folder/test1.scala => folder/test1.scala
/src/main/scala/test2.scala => test2.scala
...
- testing absolute report file paths - testing base dir relative report file paths - testing source dir relative report file paths
RadoBuransky
added a commit
that referenced
this pull request
Oct 25, 2015
Improved path handling, reported filenames are converted to src dir relative paths
|
Looks great. I will merge all PRs and will release a new version. Let's see if you broke something. Thanks! |
|
@MichaelZinsmaier: Your changes have been included in the 5.1.2 release. Thanks. https://github.com/RadoBuransky/sonar-scoverage-plugin/releases/tag/v5.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thats the 1st in a series of 3 pull request I tried to separate functionality a bit.
This one changes the treatment of the "filename" attributes in the scoverage report files. The report
files seem to vary regarding the filename format, I encountered 3 different formats
The PR adds a path cleanup step, that aligns the filenames to a source file tree and converts them all to paths relative to the source directory. This allows to adapt the code in the sensor such that files are not longer searched with **/filepath.
Additionally the test cases are not longer dependent on Unix, but run equally well on Windows.
Some Remarks:
more tests might be a good idea
an InputDir and to get that you need a resolvable filename, which sadly does not work over
FilePredicates (or I could at least not figure out how)
ok hope you find time to look through it
Best Michael