This repository was archived by the owner on Dec 28, 2019. It is now read-only.
Limit the amount the beneficiary receives (rest goes into the owner's multsig) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrettig
suggested changes
Oct 28, 2018
axic
force-pushed
the
beneficiary-limit
branch
from
ba2f4f0 to
340166c
Compare
lrettig
suggested changes
Oct 28, 2018
contracts/Market.sol
Outdated
| if (totalWithdrawn >= beneficiaryLimit) | ||
| owner().transfer(this.balance); | ||
| else { | ||
| uint256 amonut = Math.min(this.balance, beneficiaryLimit); |
Contributor
There was a problem hiding this comment.
I feel like this could be expressed more cleanly:
uint256 amountToBeneficiary = Math.min(this.balance - totalWithdrawn, beneficiaryLimit)
uint256 amountToOwner = this.balance - amountToBeneficiary
totalWithdrawn += amountToBeneficiary
_beneficiary.transfer(amountToBeneficiary)
owner().transfer(amountToOwner)
Contributor
Author
There was a problem hiding this comment.
This can be called repeatedly. It is a lot of extra gas doing those calls with 0 eth.
axic
force-pushed
the
beneficiary-limit
branch
from
340166c to
5ba159d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.