V0.2.0 release changelog, pyproject.toml update, codecov fix #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orionarcher
changed the title
| @@ -47,9 +47,7 @@ test = [ | |||
| mace = ["mace-torch>=0.3.11"] | |||
| mattersim = ["mattersim>=0.1.2"] | |||
| metatensor = ["metatensor-torch >=0.7,<0.8", "metatrain[pet] >=2025.4"] | |||
| orb = [ | |||
| "orb-models@git+https://github.com/orbital-materials/orb-models#egg=637a98d49cfb494e2491a457d9bbd28311fecf21", | |||
There was a problem hiding this comment.
Was there a reason why the Orb version pinned? Otherwise look good.
There was a problem hiding this comment.
it was pinned because they released parts of the v3 code around 2 weeks before cutting v3 release and sharing the new models. It was being pinned to the repo so that we could write the model around the new orb tooling in the knowledge v3 was coming.
janosh
reviewed
Apr 15, 2025
| @@ -47,7 +47,7 @@ jobs: | |||
| --ignore=tests/models/test_metatensor.py | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@v5 | |||
| uses: codecov/codecov-action@v5.4.0 | |||
There was a problem hiding this comment.
v5.4.2 is out so we can revert to v5 to get later releases
There was a problem hiding this comment.
Great, I can sneak this in to a future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include a summary of major changes in bullet points:
Checklist
Work-in-progress pull requests are encouraged, but please enable the draft status on your PR.
Before a pull request can be merged, the following items must be checked:
Run ruff on your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit installand a check will be run prior to allowing commits.