sanitizing bug #22
Merged
sanitizing bug #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
Contributor
There was a problem hiding this comment.
Doesn't this mean that we'll end up with redundant un-sanitized keys in the object? Because we're adding a new key but not deleting the old, un-sanitized one. Seems like we would want to start with an empty accumulator object rather than the existing conf.inCondition one (unless I'm reading this wrong).
Contributor
There was a problem hiding this comment.
Yeah I think you're right. I think it might be worth extracting this transform into a function that can be tested separately.
@VulpesArtificem
Contributor
There was a problem hiding this comment.
He's right, I misunderstood _.transform().
Contributor
|
+1 |
geoff-reid
pushed a commit
to geoff-reid/on-tasks
that referenced
this pull request
May 5, 2017
…rror throw missing credential error
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
Get graph and task definition persistence working
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
…k-dep to master * commit 'd46c676a06e09f75545cc32dbe7734c8473a4018': Ignore certain fields on deep comparison of serialized task objects
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
merge ESXi workflow and add analyze os repo task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug where not all items are sanitized
https://hwjiraprd01.corp.emc.com/browse/ODR-216