Added a job to enable arbitrary ssh commands #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (!_.contains(self.acceptedCodes, sshData.exitCode)) { | ||
| reject(sshData); | ||
| } |
Contributor
There was a problem hiding this comment.
Not an exclusive if block, if/else instead?
Contributor
|
lib/jobs/ssh-job.js
Outdated
| }); | ||
| ssh.connect({ | ||
| host: sshSettings.host, | ||
| port: 22, |
Contributor
There was a problem hiding this comment.
Can this be another input like "sshSettings.port" with a default to 22?
Contributor
|
👎 because I see a lot duplicated code between this job and linux-command, linux-catalog job, this need a code refactor |
Contributor
|
Meanwhile, @VulpesArtificem could you please add some description and user cases for the PR in future, so reviewer can understand your design before digging into the code. I guess the ssh job is used for the inband mangement, right? |
AlliumApotheosis
force-pushed
the
ssh-job
branch
from
a7471a2 to
410c88c
Compare
|
|
||
| it('should take an arbitrary number of parsed tasks and return '+ | ||
| 'an array of promises to catalog them', function() { | ||
| var tasks = Array(5).fill({source: 'test', data:'stdout', store: true}); |
There was a problem hiding this comment.
Missing 'new' prefix when invoking a constructor.
AlliumApotheosis
force-pushed
the
ssh-job
branch
2 times, most recently
from
180c4ac to
2aa8c15
Compare
| var tasks = [ | ||
| {source: 'test', data:'stdout', store: true} | ||
| {source: 'test', data:'stdout', store: true} | ||
| {source: 'test', data:'stdout', store: true} |
There was a problem hiding this comment.
Expected ')' and instead saw '{'.
Missing semicolon.
Label 'source' on test statement.
Unrecoverable syntax error. (62% scanned).
AlliumApotheosis
force-pushed
the
ssh-job
branch
from
2aa8c15 to
d2c9f4a
Compare
Contributor
|
test this please |
Contributor
|
Contributor
|
👍 |
Contributor
|
test this please |
1 similar comment
Contributor
Author
|
test this please |
| ssh.on('ready', function() { | ||
| ssh.exec(cmdObj.cmd, function(err, stream) { | ||
| if (err) { reject(err); } | ||
| stream.on('close', function(code) { |
Contributor
There was a problem hiding this comment.
Are we going to get fatal errors if we don't handle 'error' on this stream object?
Contributor
|
@VulpesArtificem can you add a quick test for the dpkg -l parser? |
Contributor
|
Otherwise, 👍 |
AlliumApotheosis
force-pushed
the
ssh-job
branch
from
9f4966d to
e1d40cd
Compare
Contributor
|
AlliumApotheosis
force-pushed
the
ssh-job
branch
from
d209825 to
4e3a677
Compare
Contributor
|
👍 |
Contributor
|
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
Disable ACPI in kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RackHD/corecommitters @heckj
Added a job for executing arbitrary commands over ssh and cataloging the results. Additionally, refactored linux catalog/command jobs into a command-util which also supports the ssh-job
requires RackHD/on-core#116