Modify local ipmi command to remove "ignoreFailure" flag #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
yyscamper
added a commit
that referenced
this pull request
Jan 15, 2016
Modify local ipmi command to remove "ignoreFailure" flag
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
updated switch discovery to update lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix ODR-339 (https://hwjiraprd01.corp.emc.com/browse/ODR-399) reporting no poller for management server.
The missing of poller is caused by missing of "bmc" source in catalogs, which is the response from "ipmitool lan print" command. In the catalog-mgmt-bmc task, the command is "ipmitool lan print || true", which is sent to a child process as parameters to ipmitool. the "|| true" is invalid parameters and caused the stderr in the response.
The solution is to remove "|| true" from command, and store it as an ignoreFailure flag to determine whether other commands will continue to process.
It might not be the best solution here, just a quick fix of 1.1.0 branch without modifying other common codes.
A more clear way about 1) adding ignore flag in workflow and 2) modify command parser will be added to master branch.