Skip to content

Added Template /DELETE support over grpc #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keedya merged 1 commit into from
Oct 3, 2017
Merged

Added Template /DELETE support over grpc #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/rpc/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ function schedulerServerFactory(
templatesLibPut: grpcWrapper(templates.templatesLibPut),
templatesMetaGet: grpcWrapper(templates.templatesMetaGet),
templatesMetaGetByName: grpcWrapper(templates.templatesMetaGetByName),
templatesLibDelete: grpcWrapper(templates.templatesLibDelete),
profilesGetLibByName: grpcWrapper(profiles.profilesGetLibByName),
profilesGetMetadata: grpcWrapper(profiles.profilesGetMetadata),
profilesGetMetadataByName: grpcWrapper(profiles.profilesGetMetadataByName),
Expand Down
8 changes: 7 additions & 1 deletion api/rpc/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
var injector = require('../../index.js').injector;
var templatesApiService = injector.get('Http.Services.Api.Templates');
var Promise = injector.get('Promise');
var templates = injector.get('Templates');

var templatesLibGet = function (call) {
return Promise.try(function() {
Expand All @@ -30,9 +31,14 @@ var templatesMetaGetByName = function (call) {
});
};

var templatesLibDelete = function (call) {
return templates.unlink(call.request.name, call.request.scope);
};

module.exports = {
templatesLibGet:templatesLibGet,
templatesLibPut:templatesLibPut,
templatesMetaGet: templatesMetaGet,
templatesMetaGetByName: templatesMetaGetByName
templatesMetaGetByName: templatesMetaGetByName,
templatesLibDelete: templatesLibDelete
};
6 changes: 6 additions & 0 deletions scheduler.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ service Scheduler {
rpc workflowsDeleteTasksByName (workflowsDeleteTasksByNameRequest) returns (HttpReply) {}
rpc templatesLibGet (templatesLibGetRequest) returns (HttpReply) {}
rpc templatesLibPut (templatesLibPutRequest) returns (HttpReply) {}
rpc templatesLibDelete (templatesLibDeleteRequest) returns (HttpReply) {}
rpc templatesMetaGet (templatesMetaGetRequest) returns (HttpReply) {}
rpc templatesMetaGetByName (templatesMetaGetByNameRequest) returns (HttpReply) {}
rpc profilesGetLibByName (profilesGetLibByNameRequest) returns (HttpReply) {}
Expand Down Expand Up @@ -141,4 +142,9 @@ message profilesPutLibByNameRequest{
string scope = 3;
}

message templatesLibDeleteRequest {
string name = 1;
string scope = 2;
}