RAC-5786 - Normalization of system-spec.js #720
Conversation
|
jenkins: depends on RackHD/on-core#284 |
|
BUILD on-http #367 : FAILURE |
|
test this please |
|
Test this please |
| }); | ||
|
|
||
| it('should return a 202 for a Dell-based bios settings patch', function() { | ||
| it('should 202 for a Dell-based bios settings patch', function() { |
There was a problem hiding this comment.
did you mean to remove 'return a' here?
| }); | ||
|
|
||
| it('should return a 202 for a Dell-based bios change password SysPassword', function() { | ||
| it('should 202 for a Dell-based bios change password SysPassword', function() { |
There was a problem hiding this comment.
did you mean to remove 'return a' here?
There was a problem hiding this comment.
I prefer the shorter form although the code is not consistent.
| return helper.request().get('/redfish/v1/Systems/' + node.id + | ||
| wsman.getLog.withArgs(sinon.match.any, 'SEL').resolves(wsmanSelLog); | ||
| return helper.request().get('/redfish/v1/Systems/' + dellNode.id + | ||
| '/LogServices/sel/Entries') |
There was a problem hiding this comment.
sel - 'SEL' or 'sel' - does it matter? since in the other script, we are switching to 'caps'.
|
|
||
| return helper.request().get('/redfish/v1/Systems/' + node.id + | ||
| return helper.request().get('/redfish/v1/Systems/' + dellNode.id + | ||
| '/LogServices/sel/Entries/23') |
There was a problem hiding this comment.
I left all of the cap sel/SEL lc/LC code alone except for one instance of LC.
|
BUILD on-http #379 : FAILURE BUILD on-http #379 Error Logs ▼Test Name: Redfish Systems Root should return a valid iDRAC sel log service Error Details: expected 200 "OK", got 500 "Internal Server Error" Response body: { error: { code: 'Base.1.0.GeneralError', message: 'A general error has occurred. See ExtendedInfo for more information.', '@Message.ExtendedInfo': [ [Object], [Object] ] } } Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)Test Name: Redfish Systems Root should return a valid iDrac sel log service entry Test Name: Redfish Systems Root should 404 an invalid iDRAC sel log service entry Test Name: Redfish Systems Root should 404 an invalid LC log service entry collection |
|
BUILD on-http #380 : FAILURE BUILD on-http #380 Error Logs ▼Test Name: Redfish Systems Root should return a valid iDRAC sel log service Error Details: expected 200 "OK", got 500 "Internal Server Error" Response body: { error: { code: 'Base.1.0.GeneralError', message: 'A general error has occurred. See ExtendedInfo for more information.', '@Message.ExtendedInfo': [ [Object], [Object] ] } } Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)Test Name: Redfish Systems Root should return a valid iDrac sel log service entry Test Name: Redfish Systems Root should 404 an invalid iDRAC sel log service entry Test Name: Redfish Systems Root should 404 an invalid LC log service entry collection |
|
BUILD on-http #381 : FAILURE BUILD on-http #381 Error Logs ▼Test Name: Redfish Systems Root should return a valid iDRAC sel log service Error Details: expected 200 "OK", got 500 "Internal Server Error" Response body: { error: { code: 'Base.1.0.GeneralError', message: 'A general error has occurred. See ExtendedInfo for more information.', '@Message.ExtendedInfo': [ [Object], [Object] ] } } Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)Test Name: Redfish Systems Root should return a valid iDRAC sel log service entry collection Test Name: Redfish Systems Root should return a valid iDrac sel log service entry Test Name: Redfish Systems Root should 404 an invalid iDRAC sel log service entry Test Name: Redfish Systems Root should return a valid lc log service Test Name: Redfish Systems Root should return a valid lc log service entry collection Test Name: Redfish Systems Root should 404 an invalid lc log service entry collection Test Name: Redfish Systems Root should return a valid lc log service entry Test Name: Redfish Systems Root should 404 an invalid lc log service entry |
| }; | ||
| // Node new mock data with OBM model change | ||
|
|
||
| var dellNodeObm ={ |
There was a problem hiding this comment.
'dellNodeObm' is defined but never used.
|
|
||
| //OBM model's mock data | ||
| var obm =[{ | ||
| var nodeObm ={ |
There was a problem hiding this comment.
'nodeObm' was used before it was defined.
* Dell vs non-dell is not handled quite right. The wsman.isDellSystem call should be allowed to succeed or fail based on the result of getNodeById. * Default resolve statements mask various blocks of code. * Add some consistency to the use of node ids. Reference object ids when possible instead of writing duplicate ids. * Fixed found issue in wsman.isDellSystem where promise chain wasn't correct.
6 participants
should be allowed to succeed or fail based on the result of getNodeById.
when possible instead of writing duplicate ids.