Skip to content

RAC-2044/ODR-952 Removed 204 response code to make congruent with swagger definition file #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anhou merged 2 commits into from
Dec 29, 2016
Merged

RAC-2044/ODR-952 Removed 204 response code to make congruent with swagger definition file #546

anhou merged 2 commits into from
Dec 29, 2016

Conversation

@lacarb
Copy link
Contributor

@lacarb lacarb commented Dec 22, 2016

/tasks/{identifier} was returning 204 whenever a task for searched for and not found or when a bad task was provided. By design, this should be returning 404 as specified in monorail-2.0.yaml. What has been removed resolves this.

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 22, 2016

BUILD on-http #2952 : ABORTED

BUILD unit-tests #10489 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists Error Details: expected 204 "No Content", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '743dc230-eb02-4fdd-8dd7-13bf25ebd6b1' } Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)

@lacarb
Copy link
Contributor Author

lacarb commented Dec 22, 2016

Test this please

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 22, 2016

BUILD on-http #2953 : UNSTABLE

BUILD unit-tests #10490 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists Error Details: expected 204 "No Content", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '1d6b491a-ab25-4d92-87a0-6e7b7b078ea7' } Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)

anhou
anhou previously approved these changes Dec 23, 2016
View reviewed changes
@anhou anhou dismissed their stale review December 23, 2016 07:54

unit test also should be updated

@anhou
Copy link
Member

anhou commented Dec 23, 2016

@lacarb from the travisci log as below, unit tests need to be updated

1) Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists:
     expected 204 "No Content", got 404 "Not Found"

@PengTian0
Copy link
Contributor

PengTian0 commented Dec 26, 2016

test this please

1 similar comment
@panpan0000
Copy link
Contributor

panpan0000 commented Dec 26, 2016

test this please

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 26, 2016

BUILD on-http #2960 : FAILURE

BUILD unit-tests #10512 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists Error Details: expected 204 "No Content", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '98a35f44-7653-4ef2-9985-a9f057dd334a' } Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)

@PengTian0
Copy link
Contributor

PengTian0 commented Dec 26, 2016

test this please

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 26, 2016

BUILD on-http #2961 : FAILURE

@PengTian0
Copy link
Contributor

PengTian0 commented Dec 26, 2016

test this please

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 26, 2016

BUILD on-http #2962 : UNSTABLE

BUILD unit-tests #10519 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists Error Details: expected 204 "No Content", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '12096b48-cf3f-41bb-85f3-d48ba8f6bbcd' } Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)
BUILD smoke-test #3964 Error Logs ▼Test Name: test_nodes_discovery Error Details: timeout waiting for task discovery -------------------- >> begin captured logging << -------------------- tests.api.v1_1.nodes_tests: INFO: Wait start time: 2016-12-26 04:08:22.382334 amqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US'] amqp: DEBUG: Open OK! kombu: INFO: Starting AMQP worker -> graph.finished.*> amqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US'] amqp: DEBUG: Open OK! kombu.mixins: INFO: Connected to amqp://guest:**@127.0.0.1:9091// amqp: DEBUG: using channel_id: 1 amqp: DEBUG: Channel open modules.worker: ERROR: subtask timeout after 1200 seconds, (id=discovery), stopping.. kombu: INFO: Stopping AMQP worker -> graph.finished.*> modules.worker: INFO: stopping subtask for discovery amqp: DEBUG: Closed channel #1 --------------------- >> end captured logging << --------------------- Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v1_1/nodes_tests.py", line 123, in test_nodes_discovery message='timeout waiting for task {0}'.format(self.__task.id)) File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 67, in assert_false raise ASSERTION_ERROR(message) "timeout waiting for task discovery\n-------------------- >> begin captured logging << --------------------\ntests.api.v1_1.nodes_tests: INFO: Wait start time: 2016-12-26 04:08:22.382334\namqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US']\namqp: DEBUG: Open OK!\nkombu: INFO: Starting AMQP worker -> graph.finished.*>\namqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US']\namqp: DEBUG: Open OK!\nkombu.mixins: INFO: Connected to amqp://guest:**@127.0.0.1:9091//\namqp: DEBUG: using channel_id: 1\namqp: DEBUG: Channel open\nmodules.worker: ERROR: subtask timeout after 1200 seconds, (id=discovery), stopping..\nkombu: INFO: Stopping AMQP worker -> graph.finished.*>\nmodules.worker: INFO: stopping subtask for discovery\namqp: DEBUG: Closed channel #1\n--------------------- >> end captured logging << ---------------------"

Test Name: teardown
Error Details: 'X-Auth-Token'
-------------------- >> begin captured logging << --------------------
modules.redfish_auth: INFO: auth already disabled.
--------------------- >> end captured logging << ---------------------
Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/redfish_1_0/session_service_tests.py", line 38, in teardown
Auth.disable()
File "/home/jenkins/workspace/on-http/RackHD/test/modules/redfish_auth.py", line 67, in disable
del config.api_client.default_headers['X-Auth-Token']
"'X-Auth-Token'\n-------------------- >> begin captured logging << --------------------\nmodules.redfish_auth: INFO: auth already disabled.\n--------------------- >> end captured logging << ---------------------"

Test Name: teardown
Error Details: 'X-Auth-Token'
-------------------- >> begin captured logging << --------------------
modules.redfish_auth: INFO: auth already disabled.
--------------------- >> end captured logging << ---------------------
Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/redfish_1_0/account_service_tests.py", line 38, in teardown
Auth.disable()
File "/home/jenkins/workspace/on-http/RackHD/test/modules/redfish_auth.py", line 67, in disable
del config.api_client.default_headers['X-Auth-Token']
"'X-Auth-Token'\n-------------------- >> begin captured logging << --------------------\nmodules.redfish_auth: INFO: auth already disabled.\n--------------------- >> end captured logging << ---------------------"

Test Name: test_node_catalogs
Error Details: Node catalog is empty!
Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 264, in test_node_catalogs
assert_not_equal(0, len(resp), message='Node catalog is empty!')
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 151, in assert_not_equal
raise ASSERTION_ERROR(message)
AssertionError: Node catalog is empty!

Test Name: test_catalogs
Error Details: Catalog dmi not found in node 5860de17fb5300f5080cca01!
Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/catalogs_tests.py", line 48, in test_catalogs
fail('Catalog {0} not found in node {1}!'.format(source,node.get('id')))
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 220, in fail
raise ASSERTION_ERROR(message)
AssertionError: Catalog dmi not found in node 5860de17fb5300f5080cca01!

Test Name: test_tag_create
Error Details: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-xDwDrjAiCeLDJFMZ2QZS1A"', 'Date': 'Mon, 26 Dec 2016 09:28:47 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"No Catalogs Found for Source (dmi).","status":"404","UUID":"c8ffcc94-6c51-4343-987a-1496278a75b9"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/tags_tests.py", line 45, in test_tag_create
tagsWithRules = self.__create_tag_rule(n.get('id'))
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/tags_tests.py", line 26, in __create_tag_rule
Api().nodes_get_catalog_source_by_id(identifier=id,source='dmi')
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 1862, in nodes_get_catalog_source_by_id
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-xDwDrjAiCeLDJFMZ2QZS1A"', 'Date': 'Mon, 26 Dec 2016 09:28:47 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"No Catalogs Found for Source (dmi).","status":"404","UUID":"c8ffcc94-6c51-4343-987a-1496278a75b9"}

Test Name: get_sku_nodes
Error Details: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-40J0CcK+snTvrZwV1Q1U3Q"', 'Date': 'Mon, 26 Dec 2016 09:28:48 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"No Catalogs Found for Source (dmi).","status":"404","UUID":"99691b06-ff84-45d3-ad27-bfd9c64483be"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/skupack_tests.py", line 148, in get_sku_nodes
Api().nodes_get_catalog_source_by_id(identifier=node_id,source='dmi')
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 1862, in nodes_get_catalog_source_by_id
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-40J0CcK+snTvrZwV1Q1U3Q"', 'Date': 'Mon, 26 Dec 2016 09:28:48 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"No Catalogs Found for Source (dmi).","status":"404","UUID":"99691b06-ff84-45d3-ad27-bfd9c64483be"}

Test Name: post_skupacks
Error Details: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-k6lVOUpq9MkJUQmgE/d6iA"', 'Date': 'Mon, 26 Dec 2016 09:28:48 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"No Catalogs Found for Source (dmi).","status":"404","UUID":"c8c93b6e-6bb5-41f7-af8e-9cbdf4c89516"}

-------------------- >> begin captured logging << --------------------
amqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US']
amqp: DEBUG: Open OK!
--------------------- >> end captured logging << ---------------------
Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/sel_alert_poller_tests.py", line 52, in post_skupacks
Api().nodes_get_catalog_source_by_id(identifier=node_id, source='dmi')
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 1862, in nodes_get_catalog_source_by_id
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
'(404)\nReason: Not Found\nHTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-k6lVOUpq9MkJUQmgE/d6iA"', 'Date': 'Mon, 26 Dec 2016 09:28:48 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})\nHTTP response body: {"message":"No Catalogs Found for Source (dmi).","status":"404","UUID":"c8c93b6e-6bb5-41f7-af8e-9cbdf4c89516"}\n\n-------------------- >> begin captured logging << --------------------\namqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/\', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US']\namqp: DEBUG: Open OK!\n--------------------- >> end captured logging << ---------------------'

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 26, 2016

BUILD on-http #2963 : FAILURE

BUILD unit-tests #10520 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists Error Details: expected 204 "No Content", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: '96b066a0-4545-4445-9cb5-c21204aca030' } Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Dec 26, 2016

BUILD on-http #2965 : UNSTABLE

BUILD unit-tests #10528 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists Error Details: expected 204 "No Content", got 404 "Not Found" Response body: { message: 'Not Found', status: '404', UUID: 'b7b1de73-e885-4470-90bd-d52c7c7de15e' } Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17) Stack Trace: Error: expected 204 "No Content", got 404 "Not Found" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:921:12)

@lacarb
Copy link
Contributor Author

lacarb commented Dec 28, 2016

@RackHD/corecommitters
Small changes to make the api congruent with the swagger doc
https://github.com/RackHD/on-http/blob/master/static/monorail-2.0.yaml#L3220-L3242

@DavidjohnBlodgett
Copy link
Contributor

DavidjohnBlodgett commented Dec 28, 2016

👍

@anhou anhou merged commit 92ecfe2 into RackHD:master Dec 29, 2016
@lacarb lacarb deleted the odr-952 branch January 4, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anhou anhou anhou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lacarb @JenkinsRHD @anhou @PengTian0 @panpan0000 @DavidjohnBlodgett