added redactions to workflows GET by :id

[DavidjohnBlodgett]

@RackHD/corecommitters

New way to resolve: https://github.com/RackHD/RackHD/issues/241
This PR depends on: RackHD/on-core#228
both PRs resolve: https://github.com/RackHD/RackHD/issues/417

this is the final PR to revert old (complex and overlapping) encryption of passwords to simply redact secret fields prior to the object being passed to the client.

[JenkinsRHD]

BUILD on-http #2843 : UNSTABLE

• ** BUILD build-config-setup #160067: SUCCESS
• ** BUILD unit-tests #10103: UNSTABLE
• ** BUILD smoke-test #3790: UNSTABLE

BUILD unit-tests #10103 Error Logs ▼

Test Name: Http.Api.Workflows.2.0 workflowsGetById should return a single persisted graph
Error Details: expected 200 "OK", got 400 "Bad Request" Response body: { message: 'sanitizer.scrub is not a function', status: '400', UUID: '0900552c-ff0d-4e11-a639-81b426eae622' } Error: expected 200 "OK", got 400 "Bad Request" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17)
Stack Trace: Error: expected 200 "OK", got 400 "Bad Request"
at Test._assertStatus (node_modules/supertest/lib/test.js:232:12)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:921:12)

Test Name: Http.Api.Workflows GET /workflows/:id should return a single persisted graph
Error Details: expected 200 "OK", got 500 "Internal Server Error" Response body: { message: 'sanitizer.scrub is not a function' } Error: expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17)
Stack Trace: Error: expected 200 "OK", got 500 "Internal Server Error"
at Test._assertStatus (node_modules/supertest/lib/test.js:232:12)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:921:12)

BUILD smoke-test #3790 Error Logs ▼

Test Name: test_workflows_id_get
Error Details: (500)
Reason: Internal Server Error
HTTP response headers: HTTPHeaderDict({'Content-Length': '47', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2f-mpirRZU2kw41cGfT9XNH0g"', 'Date': 'Wed, 16 Nov 2016 22:34:31 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"sanitizer.scrub is not a function"}

-------------------- >> begin captured logging << --------------------
urllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', BadStatusLine("''",))': /api/1.1/workflows
--------------------- >> end captured logging << ---------------------
Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v1_1/workflows_tests.py", line 73, in test_workflows_id_get
Workflows().workflows_instance_id_get(instance_id)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api1_1/apis/workflow_api.py", line 1054, in workflows_instance_id_get
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api1_1/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api1_1/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api1_1/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api1_1/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api1_1/rest.py", line 177, in request
raise ApiException(http_resp=r)
'(500)\nReason: Internal Server Error\nHTTP response headers: HTTPHeaderDict({'Content-Length': '47', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2f-mpirRZU2kw41cGfT9XNH0g"', 'Date': 'Wed, 16 Nov 2016 22:34:31 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})\nHTTP response body: {"message":"sanitizer.scrub is not a function"}\n\n-------------------- >> begin captured logging << --------------------\nurllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', BadStatusLine("''",))': /api/1.1/workflows\n--------------------- >> end captured logging << ---------------------'

Test Name: test_workflows_id_get
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '108', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6c-VGUSanmS4EwftIjp8Dm0Fg"', 'Date': 'Wed, 16 Nov 2016 22:35:15 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"sanitizer.scrub is not a function","status":"400","UUID":"9be8b8b7-cb01-4366-93fb-adc8414a0437"}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/workflows_tests.py", line 90, in test_workflows_id_get
Api().workflows_get_by_instance_id(instance_id)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 8847, in workflows_get_by_instance_id
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '108', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6c-VGUSanmS4EwftIjp8Dm0Fg"', 'Date': 'Wed, 16 Nov 2016 22:35:15 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"sanitizer.scrub is not a function","status":"400","UUID":"9be8b8b7-cb01-4366-93fb-adc8414a0437"}

[cgx027]

💯

[tldavies]

👍 once it is rerun and passes tests with the dependent PR

[benbp]

👍

[DavidjohnBlodgett]

@brianparry if you get the chance could you review this?

once the build issues with on-core are resolved, this will address masking secrets on specific api paths that a github issue was raised.

[DavidjohnBlodgett]

test this please

[DavidjohnBlodgett]

@RackHD/corecommitters this should be merge ready.

[brianparry]

👍