Remove postLookup() logic, and fix the failure of installing Esxi when setting static IP.

[lanchongyizu]

The solution is

• wget callbackScript into directory /tmp in %pre
• then move it to /vmfs/volumes/datastore1 in %post
• then copy the content into /etc/rc.local.d/local.sh

@RackHD/corecommitters @panpan0000 @keedya

[rackhdmirror]

@RackHD/corecommitters please review.

[keedya]

@lanchongyizu I m not sure ssh validation will pass in this case. I probably missed something here?

[yyscamper]

@lanchongyizu : could you please explain why this can solve the static IP issue?

[lanchongyizu]

@keedya For now, ssh validation fails for all OSes, so it is not caused by this PR.
@yyscamper Because callbackScript is wget in %pre where static IP is not set then.

[panpan0000]

:+0: :-) looks good. just questions: (1) so in %pre, the "/vmfs/volumes/datastore1" has not been established or is not accessible ? (2) can you help: why wget works in %pre but not in %firstboot ?

[lanchongyizu]

@panpan0000
(1) yes, it's not established
(2) wget in %firstboot will fail since setting static IP makes lookups fail when pulling callbackScript.

[keedya]

@lanchongyizu I tested it on my end and found that the lookup table is getting updated.
I guess we can retire postlookup functionality in the script. Do you still think you need to download the file in preboot?

👍

[yyscamper]

My comment purely depends on the test result. I eagerly to remove the "ugly" code to POST lookup in ESXi kickstart file, if the testing is OK, this is definitely 👍

[lanchongyizu]

Since the issue https://github.com/RackHD/RackHD/issues/467 exists, we can't remove postLookups() currently.

[lanchongyizu]

This has been solved by #531, so close the PR.