-
Notifications
You must be signed in to change notification settings - Fork 77
Add workflows view and unit-test #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
test this please |
|
data/views/workflows.2.0.json
Outdated
| <% if (hasOwnProperty("id")) { %> | ||
| "id": "<%=id%>", | ||
| <% } %> | ||
| <% if (hasOwnProperty("injectableName")) { %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the injectableName is required, not optional.
|
👍 after fix indent. |
|
👍 |
|
test this plesae |
|
test this please |
|
|
comment by test Jenkins, you can ignore this error |
|
Working on functional test fix. I will update after I create a PR |
|
Jenkins: depends on RackHD/RackHD#397 |
|
@changev : Can you help me with the Jenkins dependency job here? I added Jenkins: depends on --- but does not seem to be doing (unless I am missing something here). TIA |
|
@srinia6 "jenkins: depends on" just describe the dependency relationship and won't trigger a build, you need comment 'test this please' to trigger a new build, : ) |
|
test this please |
|
|
@changev : Thank you. This build doesn't look like it ran with my Functional test changes. Seeing old error, that has been fixed in my other PR. Could you help? |
|
test this please |
|
dependent on RackHD/RackHD#397 |
|
test this please |
|
| var graph = | ||
| { | ||
| "id": "foobar", | ||
| "injectableName": "foobar", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still there are a lot indent errors.
@srinia6 : There is some tool can beautify the code automatically, this will save you time to check every line, such as http://jsbeautifier.org/.
|
test this please |
|
|
Above build is not running with the other PR. |
|
test this please |
Add workflows view and unit-test.
@brianparry @keedya @dalebremner @BillyAbildgaard @RackHD/corecommitters