Skip to content

Conversation

@brianparry
Copy link
Contributor

  • Check if poller exists and return 404 if it does not.
  • Collapse getPollersByIdDataCurrent into getPollersByIdData.

@RackHD/corecommitters @srinia6 @dalebremner @BillyAbildgaard @keedya @jlongever

@keedya
Copy link

keedya commented Aug 4, 2016

👍

* Check if poller exists and return 404 if it does not.
* Collapse getPollersByIdDataCurrent into getPollersByIdData.
@brianparry
Copy link
Contributor Author

brianparry commented Aug 4, 2016

Depends on: RackHD/on-tasks#308
Supports: RackHD/RackHD#366

@srinia6
Copy link
Contributor

srinia6 commented Aug 4, 2016

+1

@JenkinsRHD
Copy link
Contributor

*** BUILD #2062 ***
Test Name: pollers_data_get
Error Details: No Content
Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/pollers_tests.py", line 156, in pollers_data_get
    assert_equal(200, result.status, message=result.reason)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
AssertionError: No Content


@benbp
Copy link
Contributor

benbp commented Aug 4, 2016

👍

@brianparry
Copy link
Contributor Author

test this please

@brianparry brianparry merged commit f7c3052 into RackHD:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants