Consistency for ways to use 2.0 API (common / current) #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keedya
commented
Jul 9, 2016
keedya
commented
- Able to switch on / by default in one place
Author
lib/services/http-service.js
Outdated
| ); | ||
|
|
||
| //re-route common and current | ||
| var varsionPath = configuration.get('versionBase') || '1.1'; |
Contributor
There was a problem hiding this comment.
versionPath instead of varsionPath?
Contributor
|
Just a nitpick on the variable name. LGTM, +1 |
- Able to switch on / by default in one place
Author
|
@zyoung51 all set |
Contributor
|
👍 |
| ); | ||
|
|
||
| //re-route common and current | ||
| var versionPath = configuration.get('versionBase') || '1.1'; |
Contributor
There was a problem hiding this comment.
@keedya I think we should add an assert or some other type of check to verify that versionBase is set to a valid value.
Contributor
|
👍 One minor comment related to config validation, but I think that's more of a general problem outside the scope of this PR. |
Contributor
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.