Add file latest and file md5 latest to south API router #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Author
|
test this please |
1 similar comment
Contributor
Author
|
test this please |
| var query = req.params.filename; | ||
|
|
||
| return fileService.verify(query) | ||
| .then(function(metadata) { |
Member
There was a problem hiding this comment.
Change to metadata[metadata.length - 1] to return the latest file. Similar to #222
Contributor
|
Still 👍 |
Contributor
Author
|
Thanks @iceiilin, just see your PR merged. |
Member
|
+1 after changing the index |
Member
|
@WangWinson suggest adding unittests for these two routers |
WangWinson
force-pushed
the
bugfix/issue_215
branch
from
05ef9f2 to
1a8ddab
Compare
Contributor
Author
|
@iceiilin @yyscamper comments addressed |
Contributor
|
Looks good to me 👍 |
Member
|
@WangWinson can we please include the unit tests with this fix? It would also likely have a positive impact to the coveralls decreased coverage noted above. thanks! |
Contributor
Author
|
@amymullins yes, I would like to. I would try best to complete my current story first. |
Contributor
|
@WangWinson These are the coverage/unittest rules Felix has posted for me in the past: +1 after the PR is amended to meet these criteria, -1 otherwise. |
Contributor
|
@amymullins @zyoung51 : I had talked about the unit-test with @WangWinson, since there is a history debt that this file doesn't have any unit-test before (see https://github.com/RackHD/on-http/blob/master/spec%2Flib%2Fapi%2F1.1%2Ffiles-spec.js) and considering the priority that this will impact multiple P1 issues that related with firmware update, so I'm acceptable to create another PR to compensate the unit-testing. Anyway, I will be very appreciated if the unit-test can be ready in this PR. |
Member
|
@yyscamper ok by me if you need/want to track in a separate story but IMO it should be of equal priority. If we had these test cases covered, we may not have had multiple P1 issues to resolve. :) |
Contributor
|
@amymullins : I agree. |
WangWinson
force-pushed
the
bugfix/issue_215
branch
from
d1ced4c to
4758efd
Compare
Contributor
|
Contributor
|
Contributor
|
👍 |
1 similar comment
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue https://github.com/RackHD/on-http/issues/215
@RackHD/corecommitters @cgx027