Clean up error handling in Swagger renderer #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianparry
force-pushed
the
views-error-handling
branch
3 times, most recently
from
7d4079c to
8dec87e
Compare
lib/services/swagger-api-service.js
Outdated
| }) | ||
| .catch(function(err) { | ||
| throw new Errors.ViewRenderError(err.message); | ||
| }) |
brianparry
changed the title
brianparry
force-pushed
the
views-error-handling
branch
from
8dec87e to
e7af139
Compare
| // Remove whitespace | ||
| return data.replace(/\s/g, ''); | ||
| }) | ||
| .catch(function(err) { |
Contributor
There was a problem hiding this comment.
Seems this catch is not necessary
Contributor
Author
There was a problem hiding this comment.
Strictly speaking, you're right. The reason I added it is to convert an AssertionError to a ViewRenderError so that the status property is set properly for the swagger render fitting. Since both AssertionError and ViewRenderError result in 500 status, it ultimately doesn't matter but there could be problems if other unexpected errors are thrown or if we decide that we want to change the status code for ViewRenderError.
Contributor
|
Still 👍 with some minor suggestion. |
Contributor
Author
|
RackHD/on-core#112 is merged, so test this please |
Contributor
|
+1 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on RackHD/on-core#112