Add local copy of swagger_router fitting #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change to swagger-node-runner (https://github.com/theganyo/swagger-node-runner/ commit/5cc5df13f0b880b1b42350e1f1d914978b066820) has not been packaged upstream yet. This commit makes the change locally and should be rolled out once the swagger-node-runner package is included into swagger-express-mw.
Contributor
Author
|
@RackHD/corecommitters @tannoa2 @uppalk1 @keedya @geoff-reid @dalebremner |
Contributor
|
👍 Looks good. I would like to somehow record that this is temporary fitting that we'll use until a swagger-node-runner release with your change is published to npm. Maybe open an issue? |
Contributor
Author
|
@brianparry I did note that this should be removed once the swagger-node-runner is updated in the commit mesage. |
Contributor
|
@zyoung51 I see it in the commit message now. Thanks! |
Contributor
|
+1 Assuming the coverage decrease is due to adding temporary code without testing it? |
jlongever
added a commit
that referenced
this pull request
Jan 28, 2016
Add local copy of swagger_router fitting
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to swagger-node-runner (https://github.com/theganyo/swagger-node-runner/
commit/5cc5df13f0b880b1b42350e1f1d914978b066820) has not been packaged upstream
yet. This commit makes the change locally and should be removed once the updated
swagger-node-runner package is included into swagger-express-mw.