fix houndci false alarm about undefined variable

[yyscamper]

Fix the annoying Hound CI false alarm for undefined variables by adding those variables into the jshint "predef" tables. (previous jshint "globals" options doesn't work well for houndci, but I tested "predef" works well, see my test PR: yyscamper/on-tasks#10)

However, by introducing this change, there will be a new false alarm emerges:

Redefinition of '_'

This is caused by you use lodash not via injectable table but directly by require('lodash').
This false alarm usually only happens in "index.js", so it is rare to happen.

@RackHD/corecommitters @WangWinson @iceiilin

[yyscamper]

Wondering why houndci report error parsing config for jshint only in on-core repo, the same config file in other repos don't have such error.

[anhou]

why remove 'files"?

[yyscamper]

The files is not referenced anywhere, there will be houndci warning.

[JenkinsRHD]

*** BUILD #89 ***

[anhou]

@yyscamper please fix the houndci

[yyscamper]

@anhou I tried to fix the houndci error "Error parsing config for: jshint" but failed, I don't know why the houndci reports some error as I uses the same .jshintrc and .hound.ym with other repos (expect on-http), but those repos doesn't have such error.

I guess this may be houndci false alarm, but cannot make sure.

@benbp any idea for this?

[JenkinsRHD]

*** BUILD #91 ***

[yyscamper]

I enabled the houndci in my forked repo, I tested not change the .jshintrc, only copy an unitest file, it shows the houndci still complains "Error parsing config for: jshint", please checked this PR:
yyscamper#2, so it proves it's not my change introduces the houndci complain.

I guess maybe it is the file format problem (dos file / linux file/...), so I find a tool compared the .hound.yml and .jshintrc with the ones in on-tasks repo in binary level per byte, the tool shows they are exactly the same file even per byte.

[yyscamper]

I finally resolved it, I reverted my change to spec/lib/common/file-loader-spec.js and keep this PR only change the .jshintrc, now houndci becomes work well. Wow!!

houndci is a strange and naughty robot !

[anhou]

@yyscamper Thanks, 👍

[iceiilin]

+1