Skip to content

Conversation

@heckj
Copy link
Member

@heckj heckj commented Dec 24, 2015

While digging around looking at how we're reconnecting automatically on MongoDB, I saw we were downlevel and had some dead code enabled, so clipping things out and upgrading us to sails-mongo 11.5, which resolves https://github.com/RackHD/RackHD/issues/56.

Notes from @frey indicate that later versions of sails-mongo may not properly support the native drivers on unix, so taking a stab at this while I'm digging out the specifics of what is and isn't supported there.

According to https://docs.mongodb.org/ecosystem/drivers/node-js/, the underlying mongodb driver of 2.0.42 supports our versions of MongoDB and of Node.js:

The only thing the docs assert it doesn't include is support for MongoDB 3.2

index.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't just comment out, remove it
👍 after removing

@heckj
Copy link
Member Author

heckj commented Dec 28, 2015

@anhou thanks, missed that one - removed the commented out code and rebased the whole stack on latest master

@anhou
Copy link
Member

anhou commented Dec 29, 2015

+1

@benbp
Copy link
Contributor

benbp commented Jan 4, 2016

Yep, you were right, DiskAdapter is no longer used (cca1c1f).

@benbp
Copy link
Contributor

benbp commented Jan 4, 2016

👍

benbp added a commit that referenced this pull request Jan 4, 2016
@benbp benbp merged commit fe2219f into RackHD:master Jan 4, 2016
@heckj heckj deleted the waterline-updates branch January 5, 2016 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants