Skip to content

Conversation

@zyoung51
Copy link
Contributor

@zyoung51 zyoung51 commented Dec 3, 2015

  • Modify the model to add 'scope' and default it to 'global'
  • Modify template retrieval to consider scope when returning documents
  • Update/modify unittests
    @RackHD/corecommitters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected use of '++'.

@zyoung51 zyoung51 force-pushed the feature/template-scope branch from cbf87f6 to 131da4b Compare December 3, 2015 21:45
@benbp
Copy link
Contributor

benbp commented Dec 3, 2015

👍

@zyoung51 zyoung51 force-pushed the feature/template-scope branch from 131da4b to cb6383a Compare December 4, 2015 13:53
- Modify the model to add 'scope' and default it to 'global'
- Modify template retrieval to consider scope when returning documents
- Update/modify unittests
@zyoung51 zyoung51 force-pushed the feature/template-scope branch from cb6383a to 6d2f92f Compare December 4, 2015 13:58
@benbp
Copy link
Contributor

benbp commented Dec 4, 2015

Still 👍

@heckj
Copy link
Member

heckj commented Dec 4, 2015

👍

benbp added a commit that referenced this pull request Dec 8, 2015
@benbp benbp merged commit cce3e65 into RackHD:master Dec 8, 2015
dalebremner pushed a commit to dalebremner/on-core that referenced this pull request Dec 1, 2017
A minor change to add VirtualBox in 'PRE-REQS / SCRIPT EXPECTATIONS'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants