disabling node4 .travis setting #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
.travis.yml
Outdated
Contributor
There was a problem hiding this comment.
matrix:
allow_failures:
- node_js: "4"
Contributor
|
+1 |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node4 builds have been providing to be unstable in timing or race conditions of some form in the extended unit test. Due to that instability, I'm proposing we disable the node4 builds for now (sorry @rolandpoulter) and work to resolving them in a branch before re-enabling node4 in travis.
Commenting out the detail in .travis.yml so we don't loose it and can re-enable in a branch to work it out.