Fix checkstyle warnings #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/common/encryption.js
Outdated
Member
There was a problem hiding this comment.
also style, 4X blanks before 'salt = salt.split('$')[2];'
rolandpoulter
force-pushed
the
master
branch
from
004ce2d to
ae7bb75
Compare
Contributor
|
+1 |
Contributor
Contributor
|
👍 |
Contributor
|
was that travis-ci build failure resolved? |
Contributor
Author
|
Pretty sure that failure is not related to the code style fixes. Most likely a false negative. |
rolandpoulter
force-pushed
the
master
branch
from
ae7bb75 to
af69a39
Compare
Contributor
Author
|
Rebased. |
Merged
Contributor
|
@RackHD/corecommitters Please merge :-) |
dalebremner
pushed a commit
to dalebremner/on-core
that referenced
this pull request
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tldavies here are the code style fixes you asked for this morning.