Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue777 buildingahu input json #778

Conversation

PGorzalka
Copy link
Contributor

This is regarding issue #777

@DaJansenGit hope this is fine

@PGorzalka PGorzalka closed this Nov 6, 2024
@PGorzalka PGorzalka reopened this Nov 6, 2024
@PGorzalka
Copy link
Contributor Author

Sorry, should have requested to merge into development, but I can't change this from here anymore. Do I need to open a new PR or can you do it?

@DaJansenGit DaJansenGit changed the base branch from master to development November 6, 2024 11:36
@DaJansenGit
Copy link
Member

Sorry, should have requested to merge into development, but I can't change this from here anymore. Do I need to open a new PR or can you do it?

Thanks for providing the PR!
I changed the target branch to development. I will take a look at the changes until tomorrow.

@DaJansenGit DaJansenGit self-requested a review November 6, 2024 11:43
Copy link
Member

@DaJansenGit DaJansenGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just had a look. This should solve the error you mentioned in #777 just fine. Even though a try except might be not the best solution here, but that is not your implementation. TL;DR: approved, thanks for the PR :)

@DaJansenGit DaJansenGit changed the base branch from development to issue777_buildingahu_input_json November 6, 2024 15:44
@DaJansenGit
Copy link
Member

I changed this again, as our CI tests will only run on branches in our repository. We will merge your changes with an additional PR into our development afterwards.

@DaJansenGit DaJansenGit merged commit 7604852 into RWTH-EBC:issue777_buildingahu_input_json Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants