Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor retrofit wall function #725

Merged

Conversation

DaJansenGit
Copy link
Member

closes #713

This should improve readability and give some more feedback to the user if a retrofit was performed or not (e.g. in case of "too modern walls" with already good u values).

@DaJansenGit DaJansenGit self-assigned this Oct 13, 2022
KremerMartin
KremerMartin previously approved these changes Oct 13, 2022
Copy link
Contributor

@KremerMartin KremerMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a Docsting for the variable calc_u. But just a suggestion. Should be fine like this already.

Copy link
Contributor

@KremerMartin KremerMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. Thanks for your work. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants