modify some errors and format some files by pycharm for nice-looking #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your great job🤗🤗! I have successfully run the code in the
examples
path with a little effort!!!However, as there are some problems when I do experiments, I want to modify a little code for more user-friendly, so I created this PR. Modified contents are as follows:
my_config.yaml
and add bge query instruction for better performance,
inmy_config.yaml
, otherwise it will yield an error when runningmake style&&make quality
to automatically format code!)from pyserini.search.lucene import LuceneSearcher
to BM25Retriever to make running dense retriever more easily (as this requires jdk21, and it is somehow unnormal to use by Python projects, I think it is better to add to readme or requirements)By the way, I think I can represent some of the users who use Pycharm, so this PR can also be considered an issue 🤗
I hope this project can get better and better, thank you for your efforts! 🤗