Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify some errors and format some files by pycharm for nice-looking #6

Merged
merged 7 commits into from
May 28, 2024

Conversation

BUAADreamer
Copy link
Contributor

@BUAADreamer BUAADreamer commented May 28, 2024

Thanks for your great job🤗🤗! I have successfully run the code in the examples path with a little effort!!!

However, as there are some problems when I do experiments, I want to modify a little code for more user-friendly, so I created this PR. Modified contents are as follows:

  1. modify replug Paper URL
  2. modify bge default path in my_config.yaml and add bge query instruction for better performance
  3. remove , in my_config.yaml, otherwise it will yield an error when running
  4. format some files to make code read more easily (I hope you would format the whole project for reading or follow LLaMA-Factory to use make style&&make quality to automatically format code!)
  5. move the from pyserini.search.lucene import LuceneSearcher to BM25Retriever to make running dense retriever more easily (as this requires jdk21, and it is somehow unnormal to use by Python projects, I think it is better to add to readme or requirements)

By the way, I think I can represent some of the users who use Pycharm, so this PR can also be considered an issue 🤗

I hope this project can get better and better, thank you for your efforts! 🤗

@ignorejjj ignorejjj merged commit 128cf7d into RUC-NLPIR:main May 28, 2024
@ignorejjj
Copy link
Member

Thanks for your contribution and valuable suggestions! I will take some time to format the overall code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants