Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Pricing Refactor #346

Merged
merged 10 commits into from
Jun 6, 2019
Merged

Pricing Refactor #346

merged 10 commits into from
Jun 6, 2019

Conversation

bonedaddy
Copy link
Contributor

@bonedaddy bonedaddy commented Jun 4, 2019

👷 Purpose

Pull in pricing changes from database to implement new pricing model

🚀 Changes

  • Free, Paid, Partner are the only tiers
  • Partner is a reserved tier for special purposes
  • Free tier limitations still in place
  • Paid tier data rate is a flat $0.07/gb
  • Free credits are no longer granted when upgrading to paid account
  • The v3 api is being removed as that is being done in a separate project for upcoming TemporalX
  • Better handling of key deletion requests to account for keys only being in 50% of keystores
  • Dependency update for kaas
  • Dependency update for database

⚠️ Breaking Changes

None as all of this is transparently implemented in the backend

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #346 into master will increase coverage by 0.23%.
The diff coverage is 18.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   52.85%   53.07%   +0.23%     
==========================================
  Files          49       42       -7     
  Lines        4570     3961     -609     
==========================================
- Hits         2415     2102     -313     
+ Misses       1656     1381     -275     
+ Partials      499      478      -21
Impacted Files Coverage Δ
cmd/temporal/main.go 52.14% <ø> (+8.36%) ⬆️
api/v2/routes_rtfs.go 31.86% <0%> (+1.36%) ⬆️
api/v2/routes_utils.go 33.78% <0%> (+0.88%) ⬆️
api/v2/routes_ipns.go 45.3% <0%> (+1.14%) ⬆️
api/v2/routes_account.go 49.43% <66.67%> (+0.56%) ⬆️
queue/ipfs.go 55.95% <0%> (+3.09%) ⬆️
queue/ipns.go 50.3% <0%> (+7.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1417906...4038804. Read the comment docs.

Because it is theoretically possible for a key to only be available in one keystore. and not the other, failing on a key delete could result in a bad state, therefore we should only warn
@bonedaddy bonedaddy merged commit 588cc09 into master Jun 6, 2019
@bonedaddy bonedaddy deleted the refactor/pricing branch June 6, 2019 00:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants