Conversation
|
I’m not very familiar with xDTD |
|
I can confirm, when running the pytest suite on my dev computer as shown below: this branch passes the same number of pytest tests as the
and the number of warnings has gone down from 67 to 63. |
| f"Downloading databases because mismatch in local versions and remote versions was found... (will take a few minutes)") | ||
| self.response = DBmanager.update_databases(response=self.response) | ||
| #os.system(f"scp {RTXConfig.db_username}@{RTXConfig.db_host}:{RTXConfig.explainable_dtd_db_path} {database}") | ||
| raise FileNotFoundError("ARAX database manager indicates that there are missing databases") |
There was a problem hiding this comment.
Thanks @saramsey for the changes. I am ok with this change if we have other scripts that can automatically check and update database version based on the config_dbs.json in advance.
There was a problem hiding this comment.
I am wondering whether the ARAX database manager can implement any pre-checking and update database version before we submit a request to ARAX system. If so, I think this change is good.
There was a problem hiding this comment.
Yes, ARAX database manager checks databases at application start-up.
There was a problem hiding this comment.
Thank you for reviewing. I will merge.
3 participants
See issue 2627 for explanation. Hoping @chunyuma or @mohsenht can review this PR>