-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp][cvitek]fix milkv-duos-sd cann't startup big-core kernel #9633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milkv-duos-sd use cv1813h folder store ld file Signed-off-by: flyingcys <flyingcys@163.com>
7aacba4
to
ad54f56
Compare
感觉就是原来代码中一段无效的逻辑,对所有的 duo 都是无效的,不仅仅是对 duo-S。 能否拿出来单独 pr,或者作为一个单独的 commit。这样以后看起来清晰一点。 其他没有问题。 |
unicornx
suggested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
见 comments
算了 , approve 了吧,上面的问题希望下次注意 |
unicornx
approved these changes
Nov 14, 2024
有个额外的问题,我看你的改动是影响的小核的链接脚本,为何标题上写的是大核跑不起来? |
BernardXiong
approved these changes
Nov 15, 2024
GuEe-GUI
pushed a commit
to GuEe-GUI/rt-thread
that referenced
this pull request
Nov 20, 2024
…ead#9633) fix milkv-duos-sd cann't startup big-core kernel milkv-duos-sd use cv1813h folder store ld file Signed-off-by: flyingcys <flyingcys@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix milkv-duos-sd cann't startup big-core kernel
milkv-duos-sd use cv1813h folder store ld file
Signed-off-by: flyingcys flyingcys@163.com
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
修复milkv-duos-sd 大核无法正常启动
你的解决方案是什么 (what is your solution)
将milkv-duo-sd相关链接文件单独存在在 cv1813h目录下,并取消预编译自动copy功能。
请提供验证的bsp和config (provide the config and bsp)
cvitek/c906_little
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up