-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp][rpi4b] add new bsp for qemu-rpi4b #9586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
用于验证的?需要有这么一份bsp吗?更多面向qemu?如果是qemu,是否可能在原bsp基础上加入相关特性?这样新开bsp,是否太过于分散了 |
这个bsp是为了长期跟进dm2.0进度,目前没有完全把旧bsp驱动迁移过来(因为dm2.0所需的ofw_gpio等关键部分尚未合并到主线),所以暂时分离出来,以后全部做好,就会删掉 |
ef2f329
to
f179954
Compare
f179954
to
164cb91
Compare
polarvid
approved these changes
Nov 5, 2024
polarvid
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
麻烦作者 rebase 一下 patch 的 commits 吧,更改为更加有效的信息。
164cb91
to
eda84d7
Compare
eda84d7
to
24daad9
Compare
polarvid
approved these changes
Nov 8, 2024
Rbb666
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
add a new bsp for rpi4b to support dm 2.0 because of some moudle of dm 2.0 not in master so create a new bsp to support qemu run . if contain the uart && sdhci driver . now it can run successful in qemu
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up