Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][rpi4b] add new bsp for qemu-rpi4b #9586

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

zhuzhuzhus
Copy link
Contributor

@zhuzhuzhus zhuzhuzhus commented Oct 28, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

add a new bsp for rpi4b to support dm 2.0 because of some moudle of dm 2.0 not in master so create a new bsp to support qemu run . if contain the uart && sdhci driver . now it can run successful in qemu

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label Oct 28, 2024
@zhuzhuzhus
Copy link
Contributor Author

@polarvid

@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label Oct 28, 2024
@BernardXiong
Copy link
Member

用于验证的?需要有这么一份bsp吗?更多面向qemu?如果是qemu,是否可能在原bsp基础上加入相关特性?这样新开bsp,是否太过于分散了

@zhuzhuzhus
Copy link
Contributor Author

用于验证的?需要有这么一份bsp吗?更多面向qemu?如果是qemu,是否可能在原bsp基础上加入相关特性?这样新开bsp,是否太过于分散了

这个bsp是为了长期跟进dm2.0进度,目前没有完全把旧bsp驱动迁移过来(因为dm2.0所需的ofw_gpio等关键部分尚未合并到主线),所以暂时分离出来,以后全部做好,就会删掉

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@polarvid polarvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦作者 rebase 一下 patch 的 commits 吧,更改为更加有效的信息。

@polarvid polarvid added the change req change requestion label Nov 5, 2024
@zhuzhuzhus zhuzhuzhus requested a review from polarvid November 6, 2024 06:40
@polarvid polarvid removed the change req change requestion label Nov 8, 2024
@polarvid polarvid added the +1 Agree +1 label Nov 8, 2024
@Rbb666 Rbb666 merged commit c1db349 into RT-Thread:master Nov 15, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants