Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BSP][GD32]add gd32e503v-eval #9574

Merged
merged 1 commit into from
Nov 2, 2024
Merged

[BSP][GD32]add gd32e503v-eval #9574

merged 1 commit into from
Nov 2, 2024

Conversation

drifting1024
Copy link
Contributor

@drifting1024 drifting1024 commented Oct 23, 2024 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

目前没有GD32E503VET6平台的porting

你的解决方案是什么 (what is your solution)

添加GD32E503VET6的官方sdk hal库，并portting到rt-thread，tshell及led灯正常工作

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp\gd32\arm\gd32e503v-eval
  • .config:CONFIG_BSP_USING_GPIO CONFIG_BSP_USING_UART CONFIG_BSP_USING_UART0 CONFIG_BSP_USING_UART1 CONFIG_BSP_USING_UART2 CONFIG_BSP_USING_UART3 CONFIG_BSP_USING_UART4 CONFIG_BSP_USING_UART5

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Oct 23, 2024
@github-actions github-actions bot added the action github action yml imporve label Oct 23, 2024
@supperthomas
Copy link
Member

感谢提交bsp。非常好的提交，ci这里请修改bsp_buildings.yml文件即可

@drifting1024
Copy link
Contributor Author

感谢提交bsp。非常好的提交，ci这里请修改bsp_buildings.yml文件即可

已修改

@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label Oct 25, 2024
@supperthomas
Copy link
Member

ci 检查有错误。

@supperthomas
Copy link
Member

image

@drifting1024
Copy link
Contributor Author

ci 检查有错误。

check again

@drifting1024
Copy link
Contributor Author

格式化工具行为不太符合预期，最后一个文件我手动更改的...

@drifting1024
Copy link
Contributor Author

@supperthomas

@supperthomas
Copy link
Member

感谢提交PR， 可否把libraries中的编译不需要的文件删掉一些。或者参考nrf5x将libraries放到软件包中
https://github.com/RT-Thread/rt-thread/tree/master/bsp/nrf5x/nrf52840
软件包不熟悉的话，可以尝试删掉一些不需要的文件比如USB libraries。 BSP仓库已经很大了。

@drifting1024
Copy link
Contributor Author

@supperthomas ok了

@drifting1024
Copy link
Contributor Author

drifting1024 commented Oct 31, 2024 •
edited
Loading

@Rbb666 合并了commit

@drifting1024 drifting1024 changed the title [GD32]add gd32e503v-eval [BSP][GD32]add gd32e503v-eval Oct 31, 2024
@mysterywolf mysterywolf merged commit 3a696eb into RT-Thread:master Nov 2, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

@mysterywolf mysterywolf mysterywolf approved these changes

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

Assignees
No one assigned
Labels
action github action yml imporve BSP: GD32 BSP related with GD32 BSP: new bsp board New added bsp, need sync action BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drifting1024 @CLAassistant @supperthomas @mysterywolf @Rbb666