Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP 为LPC4088 更换新的Libraries 产品中验证通过 #9528

Merged
merged 0 commits into from
Oct 14, 2024

Conversation

meng-plus
Copy link
Contributor

@meng-plus meng-plus commented Oct 12, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

更新lpc4088的厂家驱动库,旧的工程封装不合理,新版本更加自由友好

你的解决方案是什么 (what is your solution)

替换工程库,在产品中测试通过

  1. 并新增 片内eeprom操作
  2. 外设初始化 调整到hal_msp.c结构更加友好
  3. sdram初始化流程使用官方库中方案,在初始化全局变量前启用
  4. 增加lcd驱动
  5. 增加spifi驱动

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp\nxp\lpc\lpc408x
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@meng-plus meng-plus requested a review from Rbb666 as a code owner October 12, 2024 02:55
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Oct 12, 2024
@aozima
Copy link
Member

aozima commented Oct 12, 2024

新的Libraries是否加入软件包中?关联 #9519

@meng-plus
Copy link
Contributor Author

新一期的参考

没有,现在新的 操作都考虑往里面迁移了么 ,那我需要看看怎么做再提交pr

@Rbb666 Rbb666 merged commit 5010c17 into RT-Thread:master Oct 14, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: NXP Code related with NXP BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants