Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components][lwip]replace RT_LWIP_NETIF_NAMESIZE with RT_NAME_SIZE #9444

Closed
wants to merge 1 commit into from

Conversation

zmshahaha
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

lwip的netif名字长度是NETIF_NAMESIZE,netdev是RT_NAME_MAX,可能不一样,注册netdev(长度RT_NAME_MAX)是在lwip框架中使用netif(长度NETIF_NAMESIZE)的名字注册,可能会出现名字截断可能导致不能按驱动注册的名字找到netdev

你的解决方案是什么 (what is your solution)

合并这两个名字长度

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

这个内存消耗会不会很大

@polarvid
Copy link
Contributor

这个内存消耗会不会很大

同意。这部分配置本身是存在的,没有合理的理由不应该取消这个功能需求。

合理的修复应该是在驱动注册时选择两个配置中最小的那个。

@polarvid polarvid self-requested a review September 14, 2024 05:39
@zmshahaha
Copy link
Contributor Author

感觉这个问题影响不大,我关了吧

@zmshahaha zmshahaha closed this Sep 14, 2024
@zmshahaha zmshahaha deleted the netifname branch September 18, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants