[bsp/cvitek] new pinmux design #9188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicornx
added
BSP: Cvitek
heyuanjie87
approved these changes
Jul 15, 2024
|
注意，这个 PR 包含了两个 commit，merge 时请务必保留两个 commit，不要压缩。设计为两个 commit 也是为了方便以后回溯。 |
|
fixed #8934 |
polarvid
suggested changes
Jul 16, 2024
bsp/cvitek/drivers/drv_pinmux.c
Outdated
There was a problem hiding this comment.
这个文件缺少版权头吧？这个应该是源文件强制的。
accept
bsp/cvitek/drivers/drv_pinmux.h
Outdated
Comment on lines
432
to
445
| /* | ||
| * @whitelist: pin name whilelist which is allowed to set. Ignore check if NULL. | ||
| * NOTE: whitelist should be a string list ended with NULL. | ||
| * RETURN: | ||
| * - RT_EOK | ||
| * - else: something wrong occurred and config is abandoned. | ||
| */ |
There was a problem hiding this comment.
建议与 src 目录代码保持一致，使用 doxygen 语法注释 API。这样也可以自动生成文档。
There was a problem hiding this comment.
建议与 src 目录代码保持一致，使用
doxygen语法注释 API。这样也可以自动生成文档。
accept
The contents of the SOC type part in the Kconfig configuration are retained, and other parts related to I2C pin multiplexing selection have been rolled back. Signed-off-by: Chen Wang <unicorn_wang@outlook.com> Reviewed-by: Yuanjie He <943313837@qq.com> Reviewed-by: Shell <smokewood@qq.com>
In the new design, we require the user to manually enter the PinName (as a string) in menuconfig instead of being given menu items to select. The original method will lead to too many menu item-related macros being defined in the code, causing ifdef and other codes scatter everywhere in the driver code, which is inconvenient to maintain. The new design adds a pinmux driver module to manage the multiplexing of pins. This patch provides this driver module. P.S., the reason why users are allowed to specify pinname in a string instead of the pin number is mainly because the technical manual provided by the SOC manufacturer does not have numbers for some pins, only names. Signed-off-by: Chen Wang <unicorn_wang@outlook.com> Reviewed-by: Yuanjie He <943313837@qq.com> Reviewed-by: Shell <smokewood@qq.com>
polarvid
approved these changes
Jul 16, 2024
Rbb666
approved these changes
Jul 16, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
注意，这个 PR 包含了两个 commit，merge 时请务必保留两个 commit，不要压缩。设计为两个 commit 也是为了方便以后回溯。
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
原先的管脚复用配置机制设计不好，会导致我们在 Kconfig 中写大量 board 区分代码，导致 Kconfig 文件过大。现修改为新的配置方式。具体见 commit 的描述。
你的解决方案是什么 (what is your solution)
具体见 commit 的描述。
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up