-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components][SPI][spi-bit-ops]修复可能的异常操作 #9124
base: master
Are you sure you want to change the base?
Conversation
* 移除初始化时未进行引脚初始化就进行引脚设置可能导致的异常 * CS引脚配置判断完善 * xfer返回值优化
我觉得1、2commit没有问题,3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177 |
行;第3个commit的话,最少也得把这个头文件宏改掉,不然肯定有问题
|
第4个的话,应该来说SPI没有啥速率规定;现在仅用了一个常规条件下能够接收的超时时间; |
|
还剩下最后一个commit没有合入 [STM32][SPI]根据频率计算收发超时时间 是否直接让用户通过config配置好超时时间更加简单粗暴而且十分明了呢? |
|
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
spi.h 修改为spi_core.h 防止bsp中包含同样名称.h导致编译异常
[[STM32][SPI]根据频率计算收发超时时间] 编写测试 W25Q128 FLASH正常 读取
模拟SPI编译通过,未进行实际测试;
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up