Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp]stm32工程生成路径在源码目录 #7761

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

meng-plus
Copy link
Contributor

@meng-plus meng-plus commented Jun 30, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#7583

你的解决方案是什么 (what is your solution)

# include libraries

objs.extend(SConscript(os.path.join(libraries_path_prefix, stm32_library, 'SConscript')))

# include drivers

objs.extend(SConscript(os.path.join(libraries_path_prefix, 'HAL_Drivers', 'SConscript')))

命令使用错误,调整为如下方式即可

# include libraries

objs.extend(SConscript(os.path.join(libraries_path_prefix, stm32_library, 'SConscript'), variant_dir='build/libraries/'+stm32_library, duplicate=0))

# include drivers

objs.extend(SConscript(os.path.join(libraries_path_prefix, 'HAL_Drivers', 'SConscript'),variant_dir='build/libraries/'+'HAL_Drivers', duplicate=0))

修改参考

objs.extend(SConscript(Rtt_Root + '/src/SConscript', variant_dir=kernel_vdir + '/src', duplicate=0))

在什么测试环境下测试通过 (what is the test environment)

scons 测试通过,

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

@meng-plus
Copy link
Contributor Author

同时搜索此命令(objs.extend(SC)调用位置,发现大量bsp均有错误使用,但是由于工作量较大,当前我仅修改了stm32 作为参考
另外又发现汇编文件的生成仍在在源码路径,推测是 *.s文件不在当前路径下导致

@Guozhanxin Guozhanxin added +1 Agree +1 +2 Agree +2 labels Jul 3, 2023
@Guozhanxin Guozhanxin merged commit 72a6c91 into RT-Thread:master Jul 3, 2023
@meng-plus meng-plus deleted the bugfix/externd_Sconscript branch July 3, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants