Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atomic]修复bsp/simulator vs2019编译下 atomic 两个volatile的问题 #7736

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

zhkag
Copy link
Member

@zhkag zhkag commented Jun 27, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf requested a review from Guozhanxin June 27, 2023 14:06
@mysterywolf mysterywolf added the +1 Agree +1 label Jun 27, 2023
@BernardXiong
Copy link
Member

这些volatile应该有还是不应该有?

是否可以把C11,C++11的std atomic标准都列下?rt_atomic这部分的实现应该是完全依照着标准的接口规范来实现吧

@mysterywolf mysterywolf added the in progress PR/issue in progress. label Jun 28, 2023
@zhkag
Copy link
Member Author

zhkag commented Jun 28, 2023

C++11 都被重载为volatile和non-volatile两个版本

image

C11 中好像没有 volatile 的定义

image

@mysterywolf mysterywolf added +2 Agree +2 and removed in progress PR/issue in progress. labels Jun 29, 2023
@mysterywolf mysterywolf requested a review from BernardXiong June 29, 2023 14:46
@BernardXiong
Copy link
Member

C中有volatile的定义

@BernardXiong BernardXiong merged commit bce92ed into RT-Thread:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants