[bsp][yichip] add yc3122-pos #7526

zhiqiandeng · 2023-05-18T08:06:55Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

添加 yc3122 rt-thread 示例

你的解决方案是什么 (what is your solution)

基本yc3122 搭建

在什么测试环境下测试通过 (what is the test environment)

yc3122-pos
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

bsp/yichip/yc3122-pos/drivers/ports/fal/fal_flash_stm32l4_port.c

bsp/yichip/yc3122-pos/rtconfig.h

Guozhanxin · 2023-05-18T09:25:45Z

没有readme文件啊，加一个吧，还有下面这个文件不需要吧，删了吧

supperthomas · 2023-05-18T15:03:35Z

rt-thread/.github/workflows/action.yml

Line 52 in a294d7d

- "synwit/swm320"

scons 支持了吗？支持的话可以在这里添加

BernardXiong · 2023-05-19T03:34:01Z

这颗芯片是否太小众，太专业化了？如果是这样，是否有不必须提交上来？

bsp/yichip/yc3122-pos/README.md

Guozhanxin · 2023-05-19T03:49:16Z

bsp/yichip/yc3122-pos/README.md

+
+YC3121-pos 开发板板载资源如下：
+
+- MCU：YC3122  ARM 32-bit Cortex-M0和RISC V 双核处理器，RISC V支持浮点算法主频 192MHz，512KB/1MB/4MB FLASH ，320KB SRAM


看起来，芯片还挺强呀

芯片是否太小众，太专业化了？如果是这样，是否有不必须提交上来？

可作为通用mcu使用，各个功能都有，后期可以把相应设备补全

…t file

bsp/yichip/yc3122-pos/EventRecorderStub.scvd

mysterywolf · 2023-05-20T05:31:43Z

bsp/yichip/yc3122-pos/rtconfig.h

+#define RT_USING_MTD_NOR
+#define RT_USING_SPI
+#define RT_USING_SFUD
+#define RT_SFUD_USING_SFDP
+#define RT_SFUD_USING_FLASH_INFO_TABLE
+#define RT_SFUD_SPI_MAX_HZ 50000000


这块涉及到SPI FLash的可否设计一个开关，用户可以选择打开或者关闭？
参考：https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/stm32l475-atk-pandora/board/Kconfig#L65

只要不是核心功能，尽可能在board/Kconfig里采用开关的方式实现，默认为n，用户需要的时候才会开启。一般外设默认只开启控制台串口和GPIO

bsp/yichip/yc3122-pos/Libraries/SConscript

add yichip/yc3122-pos

supperthomas · 2023-05-22T03:16:06Z

https://github.com/RT-Thread/rt-thread/actions/runs/5041305416/jobs/9040879639

请看下编译log，确认需要提交的文件都已经提交。

…new2

zhiqiandeng · 2023-05-22T12:02:22Z

RT-Thread BSP build check / riscv64-unknown (pull_request)
这个错误编的不是我提的这个bsp吧

supperthomas · 2023-05-22T13:33:05Z

RT-Thread BSP build check / riscv64-unknown (pull_request) 这个错误编的不是我提的这个bsp吧

https://github.com/RT-Thread/rt-thread/actions/runs/5046383085/jobs/9051816950?pr=7526 现在再看下，出错的地方。

supperthomas · 2023-05-22T13:44:00Z

.config 文件可以加一下。

mysterywolf · 2023-05-22T23:02:41Z

RT-Thread BSP build check / riscv64-unknown (pull_request) 这个错误编的不是我提的这个bsp吧

这个错误无需理会

mysterywolf · 2023-05-22T23:05:14Z

.config是一个很重要的文件，它保存了menuconfig的默认设置情况，这个文件需要提交一下。在menuconfig的时候就会自动生成的。这个文件不需要手动修改什么。

…new2

zhiqiandeng · 2023-05-23T02:21:30Z

.config是一个很重要的文件，它保存了menuconfig的默认设置情况，这个文件需要提交一下。在menuconfig的时候就会自动生成的。这个文件不需要手动修改什么。

已提交

supperthomas · 2023-05-23T02:36:46Z

bsp/yichip/yc3122-pos/Libraries/SConscript

+import rtconfig
+cwd     = GetCurrentDir()
+src = Glob('sdk/*.c')
+CPPPATH = [cwd + '/sdk', cwd + '/core',cwd + '\CMSIS\Include',cwd + '\CMSIS\Device\YICHIP\YC3122\Include',cwd]


这里左斜杠和右斜杠混用，可以统一一下。

这块建议用os.path.join来链接，否则在不同操作系统下可能要出问题
os.path.join(cwd, 'CMSIS', 'Include') 这样子

这块建议用os.path.join来链接，否则在不同操作系统下可能要出问题 os.path.join(cwd, 'CMSIS', 'Include') 这样子

已修改

supperthomas · 2023-05-23T07:32:45Z

感谢贡献。

zhiqiandeng added 2 commits May 18, 2023 11:36

add new branch

8707c78

[bsp][yichip]yc3122-pos rm unuserd file

118a117

Guozhanxin reviewed May 18, 2023

View reviewed changes

bsp/yichip/yc3122-pos/drivers/ports/fal/fal_flash_stm32l4_port.c Outdated Show resolved Hide resolved

Guozhanxin reviewed May 18, 2023

View reviewed changes

bsp/yichip/yc3122-pos/rtconfig.h Outdated Show resolved Hide resolved

Guozhanxin reviewed May 19, 2023

View reviewed changes

bsp/yichip/yc3122-pos/README.md Outdated Show resolved Hide resolved

Guozhanxin reviewed May 19, 2023

View reviewed changes

zhiqiandeng added 8 commits May 19, 2023 14:21

[bsp][yichip]yc3122-pos mod file

b04ab50

[bsp][yichip]yc3122-pos mod1 file

c66ac8a

[bsp][yichip]yc3122-pos mod README main rtconfing file

59c040a

[bsp][yichip]yc3122-pos .ignore_format.yml file

7e69096

[bsp][yichip]yc3122-pos main.c file

68e7932

[bsp][yichip]yc3122-pos/drivers/pos/fal_falsh_yc3122_port.c mod forma…

1b0e057

…t file

[bsp][yichip]yc3122-pos/drivers/mod format file

662b770

[bsp][yichip]yc3122-pos/drivers/mod format file

87dfc75

Guozhanxin added the BSP label May 19, 2023

Guozhanxin reviewed May 19, 2023

View reviewed changes

bsp/yichip/yc3122-pos/EventRecorderStub.scvd Outdated Show resolved Hide resolved

[bsp][yichip]yc3122-pos rf unused file

825956a

Guozhanxin approved these changes May 19, 2023

View reviewed changes

Guozhanxin added the +1 Agree +1 label May 20, 2023

mysterywolf reviewed May 20, 2023

View reviewed changes

supperthomas reviewed May 21, 2023

View reviewed changes

bsp/yichip/yc3122-pos/Libraries/SConscript Show resolved Hide resolved

mysterywolf added the in progress PR/issue in progress. label May 21, 2023

supperthomas added 2 commits May 22, 2023 10:54

Update action.yml

f6cf991

add yichip/yc3122-pos

Update action.yml

c0f6186

zhiqiandeng and others added 2 commits May 22, 2023 13:51

[bsp][yichip]yc3122-pos add qspi lib file

cb9974f

Update action.yml

bac0f60

Merge branch 'new2' of https://github.com/zhiqiandeng/rt-thread into …

f20dbe1

…new2

Update action.yml

cf10fbe

zhiqiandeng added 2 commits May 23, 2023 10:15

[bsp][yichip]yc3122-pos add .confing file

68daf40

Merge branch 'new2' of https://github.com/zhiqiandeng/rt-thread into …

a1aaade

…new2

supperthomas approved these changes May 23, 2023

View reviewed changes

mysterywolf approved these changes May 23, 2023

View reviewed changes

supperthomas requested changes May 23, 2023

View reviewed changes

zhiqiandeng added 2 commits May 23, 2023 11:47

[bsp][yichip]yc3122-pos mod SConscript file

4df9c0d

[bsp][yichip]yc3122-pos mod SConscript file

7ad2825

supperthomas approved these changes May 23, 2023

View reviewed changes

supperthomas removed the in progress PR/issue in progress. label May 23, 2023

supperthomas merged commit 17ce4a4 into RT-Thread:master May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bsp][yichip] add yc3122-pos #7526

[bsp][yichip] add yc3122-pos #7526

zhiqiandeng commented May 18, 2023 •

edited

Loading

Guozhanxin commented May 18, 2023

supperthomas commented May 18, 2023

BernardXiong commented May 19, 2023

Guozhanxin May 19, 2023

zhiqiandeng May 19, 2023

mysterywolf May 20, 2023

mysterywolf May 20, 2023

supperthomas commented May 22, 2023

zhiqiandeng commented May 22, 2023

supperthomas commented May 22, 2023

supperthomas commented May 22, 2023

mysterywolf commented May 22, 2023

mysterywolf commented May 22, 2023

zhiqiandeng commented May 23, 2023

supperthomas May 23, 2023

mysterywolf May 23, 2023

zhiqiandeng May 23, 2023

supperthomas commented May 23, 2023


		YC3121-pos 开发板板载资源如下：

		- MCU：YC3122 ARM 32-bit Cortex-M0和RISC V 双核处理器，RISC V支持浮点算法主频 192MHz，512KB/1MB/4MB FLASH ，320KB SRAM

[bsp][yichip] add yc3122-pos #7526

[bsp][yichip] add yc3122-pos #7526

Conversation

zhiqiandeng commented May 18, 2023 • edited Loading

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Guozhanxin commented May 18, 2023

supperthomas commented May 18, 2023

BernardXiong commented May 19, 2023

Guozhanxin May 19, 2023

Choose a reason for hiding this comment

zhiqiandeng May 19, 2023

Choose a reason for hiding this comment

mysterywolf May 20, 2023

Choose a reason for hiding this comment

mysterywolf May 20, 2023

Choose a reason for hiding this comment

supperthomas commented May 22, 2023

zhiqiandeng commented May 22, 2023

supperthomas commented May 22, 2023

supperthomas commented May 22, 2023

mysterywolf commented May 22, 2023

mysterywolf commented May 22, 2023

zhiqiandeng commented May 23, 2023

supperthomas May 23, 2023

Choose a reason for hiding this comment

mysterywolf May 23, 2023

Choose a reason for hiding this comment

zhiqiandeng May 23, 2023

Choose a reason for hiding this comment

supperthomas commented May 23, 2023

zhiqiandeng commented May 18, 2023 •

edited

Loading