Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bsp lpc55sxx #6897

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Bsp lpc55sxx #6897

merged 5 commits into from
Feb 2, 2023

Conversation

yandld
Copy link
Contributor

@yandld yandld commented Feb 2, 2023

拉取/合并请求描述:(PR description)

[

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

1. add i2c DMA mode
2. enable rtc driver
using formmating.py for format code
1. update sdif driver, enable DFS, FAT32
2. update rtc driver
@mysterywolf
Copy link
Member

mysterywolf commented Feb 2, 2023

可以合并了的话,请在评论中告知

@BernardXiong BernardXiong added the BSP: NXP Code related with NXP label Feb 2, 2023
@BernardXiong
Copy link
Member

可以合并了的话,请在评论中告知

后面统一都由NXP BSP维护人 @xinyigao11 or @xinyigao 确认后进行合并

@mysterywolf
Copy link
Member

mysterywolf commented Feb 2, 2023

gaoxinyi 是负责imxrt部分的吧。
@yandld 是NXP方面指定的lpc55sxx维护者

@xinyigao
Copy link
Contributor

xinyigao commented Feb 2, 2023 via email

@mysterywolf mysterywolf added the +1 Agree +1 label Feb 2, 2023
@BernardXiong
Copy link
Member

提交的是我们nxp同事,以后也由他负责lpc相关的维护和支持

收到

@BernardXiong BernardXiong merged commit 83bd861 into RT-Thread:master Feb 2, 2023
@yandld
Copy link
Contributor Author

yandld commented Feb 3, 2023

hello RT-Team,

我是 gaoxinyi 同事: 杨熙,负责NXP LPC bsp 的。 gaoxinyi只负责imixrt。

@yandld yandld deleted the bsp_lpc55sxx branch February 10, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: NXP Code related with NXP +1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants