Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch32]对接了rt_hw_context_switch_interrupt接口 #6749

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

linshire
Copy link
Contributor

@linshire linshire commented Dec 17, 2022

拉取/合并请求描述:(PR description)

[
对接了rt_hw_context_switch_interruptC(rt_ubase_t from, rt_ubase_t to, rt_thread_t from_thread, rt_thread_t to_thread)接口,使得ch32v103能够成功编译,已经测试,能够成功编译。
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

…_thread_t from_thread, rt_thread_t to_thread)接口
@linshire linshire changed the title 对接了rt_hw_context_switch_interrupt接口 [ch32]对接了rt_hw_context_switch_interrupt接口 Dec 17, 2022
libcpu/risc-v/ch32v1/cpuport.c Outdated Show resolved Hide resolved
Co-authored-by: Man, Jianting (Meco) <920369182@qq.com>
@mysterywolf
Copy link
Member

郭老师 这块是有什么历史问题嘛?为什么有些bsp只有两个参数?rt_hw_context_switch_interrupt(rt_ubase_t from, rt_ubase_t to) @Guozhanxin

@mysterywolf mysterywolf added the +1 Agree +1 label Dec 20, 2022
@Guozhanxin
Copy link
Member

郭老师 这块是有什么历史问题嘛?为什么有些bsp只有两个参数?rt_hw_context_switch_interrupt(rt_ubase_t from, rt_ubase_t to) @Guozhanxin

smart刚改的,不知道为啥加了俩参数。不过因为这个函数的实现一般都是汇编,所以应该是兼容的。对于用c语言实现的就不兼容了。

@Guozhanxin Guozhanxin added the +2 Agree +2 label Dec 22, 2022
@Guozhanxin Guozhanxin merged commit c930b4f into RT-Thread:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants