Add lvgl adaptation of touch screen xpt2046 for BSP #6114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysterywolf
approved these changes
Jun 27, 2022
Guozhanxin
approved these changes
Jun 28, 2022
Guozhanxin
reviewed
Jun 28, 2022
| }; | ||
| typedef struct rt_xpt2046 *rt_xpt2046_t; | ||
|
|
||
| struct calibrate_args |
There was a problem hiding this comment.
看起来这个校准的操作，并没有很通用，是不是不用加到触摸框架里？
Guozhanxin
reviewed
Jun 28, 2022
| struct calibrate_args cali_args; | ||
| cali_args.lcd_name = TFTLCD_DEVICE_NAME; | ||
| cali_args.touch_name = TOUCH_DEVICE_NAME; | ||
| if (rt_device_control(touch, RT_TOUCH_CTRL_CALIBRATE, (void *)&cali_args) != RT_EOK) |
There was a problem hiding this comment.
这里直接进行触摸校准就好了吧，不用转到框架，再让框架调用校准命令。
|
@Guozhanxin 下次类似的，+1（后续一定时间没有+2的，例如5天 - 1周），+2后的，直接合并。如果涉及到内核，组件等一类的，如果觉得有歧义或安稳些的，可以稍等等 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
原BSP的LVGl部分仅适配了电容触摸屏，现加入电阻触摸屏xpt2046驱动，在stm32f407-atk-explorer板子上完成测试.
单独触摸屏测试：
配合LVGL测试：
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up