[kernel]【示例】如何给RT-Thread提交PR | beautify code#5890
Merged
BernardXiong merged 1 commit intoRT-Thread:masterfrom Apr 29, 2022
Merged
[kernel]【示例】如何给RT-Thread提交PR | beautify code#5890BernardXiong merged 1 commit intoRT-Thread:masterfrom
BernardXiong merged 1 commit intoRT-Thread:masterfrom
Conversation
supperthomas
approved these changes
Apr 28, 2022
Guozhanxin
approved these changes
Apr 28, 2022
Member
|
😵💫 这个是要合并吗? |
Member
Author
|
是的 这个合并掉,是配合这个用的 https://club.rt-thread.org/ask/article/e19f1f0f77fbd119.html |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个PR展示了如何给RT-Thread提交PR (Pull Request, 代码拉取请求)
我的水平可以给RT-Thread提交PR嘛?
完全不用有这个心理负担,不要认为自己的水平不够,开源项目就是一个大家一起来找茬的过程,无论这个“茬”是大是小,对于RT-Thread代码的迭代发展都是很重要的。
提PR一定是要找到RT-Thread的bug才能提?
不一定,就比如这个PR,可以看到,这只是对RT-Thread代码的美化,并没有实质性的修改RT-Thread的任何源码。但是! 这种美化(不限于增加注释,美化代码结构等)对于RT-Thread来说也是非常重要的!因为能够让别人清晰、明了、舒服地阅读代码也是非常重要的!因此不要认为我是小白,我就不能给RT-Thread贡献代码。
我们接收任何对RT-Thread源码迭代发展有益的PR,无论这个PR是大是小,均可!
教程
[1] 请参考视频 从0教你如何给RT-Thread贡献代码
[2] 欢迎 点此论坛文章 加群,群内有人指导你如何提交PR
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up