Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp/stm32] add usbcdc for openmv #5702

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

Miaowulue
Copy link
Contributor

@Miaowulue Miaowulue commented Mar 23, 2022

拉取/合并请求描述:(PR description)

[
Add usbcdc for openmv.
Has tested on openmv-h7plus
完成了引脚、时钟配置和Kconfig修改。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2022

CLA assistant check
All committers have signed the CLA.

@Miaowulue Miaowulue force-pushed the openmv_h7plus branch 2 times, most recently from 34bdc3c to 26b85d1 Compare March 23, 2022 15:12
@mysterywolf
Copy link
Member

如果是正常的STM32开发板或者最小系统板子,是要求只默认开启GPIO和串口。
但是由于这个是openmv的板子,是一种有某种特定目的的板子,因此可以考虑将需要板载资源默认全部开启(例如SPIFLASH USB之类),并且将USBCDC直接配置好,配置好之后,Kconfig配置的内容是会被保留下来的,下次开启menuconfig,会直接展示出配置好的内容,这样用户也无需再配置一次了。

@mysterywolf
Copy link
Member

@supperthomas 涛哥 这位贡献者你认识吗 如果不认识可以考虑拉进你们的小组呀

@mysterywolf mysterywolf added the BSP: STM32 BSP related with ST/STM32 label Mar 23, 2022
@supperthomas
Copy link
Member

supperthomas commented Mar 24, 2022

@Miaowulue 非常感谢PR。建议下次一些可以不用提交的文件,下次可以不用提交。尽量减少git的大小。比如.config .mxproject 这些不影响后面开发者使用的文件以及不是特别需要修改的文件,可以选择不用提交,有需要大修改的时候,可以一次性提交。欢迎参加社区小组,一起来PR。

@supperthomas
Copy link
Member

@supperthomas 涛哥 这位贡献者你认识吗 如果不认识可以考虑拉进你们的小组呀

应该是群里的小雨吧。

@mysterywolf
Copy link
Member

@supperthomas .config .mxproject 这些文件我是建议要提交的 因为.config是保存了kconfig的一些设置,如果没有.config,就会导致kconfig设置都是默认设置,会出问题。

@supperthomas
Copy link
Member

@supperthomas .config .mxproject 这些文件我是建议要提交的 因为.config是保存了kconfig的一些设置,如果没有.config,就会导致kconfig设置都是默认设置,会出问题。

嗯,我的意思是不用每次提交。整理好了,一次性修改即可。

@mysterywolf
Copy link
Member

嗯,我的意思是不用每次提交。整理好了,一次性修改即可。

这个到没啥事,提交的时候不看就是了,但是该提交还是得提交的。否则比如,一些int类型的数据我有一些个性化的设置,这个是不能通过类似于select的方式预设的。如果漏提交.config 这些数据就会丢失掉恢复成默认值就很难受了

@mysterywolf
Copy link
Member

@Miaowulue 请发邮件ping我一下,jiantingman@foxmail.com 我会拉你进群

@mysterywolf mysterywolf added the +1 Agree +1 label Mar 24, 2022
@mysterywolf mysterywolf requested a review from Guozhanxin March 24, 2022 01:52
@fortunerains
Copy link
Contributor

@supperthomas 涛哥 这位贡献者你认识吗 如果不认识可以考虑拉进你们的小组呀

应该是群里的小雨吧。

不是我,是我们团队的另一个人

@BernardXiong BernardXiong added the wait_+2 wait for "+2" to confirm label Mar 24, 2022
@mysterywolf mysterywolf added +2 Agree +2 and removed wait_+2 wait for "+2" to confirm labels Mar 25, 2022
@BernardXiong BernardXiong merged commit c4b62a9 into RT-Thread:master Mar 25, 2022
@Miaowulue Miaowulue deleted the openmv_h7plus branch April 13, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 +1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants