fix bug: free rbb after have freed its members#2921
Closed
kydong wants to merge 3 commits into
Closed
Conversation
|
|
rtthread-bot
requested changes
Aug 5, 2019
BernardXiong
reviewed
Aug 5, 2019
| rt_free(rbb); | ||
| rt_free(rbb->buf); | ||
| rt_free(rbb->blk_set); | ||
| rt_free(rbb); |
Member
There was a problem hiding this comment.
Please pay attention to indentation.
rtthread-bot
requested changes
Aug 5, 2019
rtthread-bot
requested changes
Aug 5, 2019
armink
reviewed
Aug 6, 2019
|
|
||
| new_rbb = find_empty_blk_in_set(rbb); | ||
|
|
||
| if (rt_slist_len(&rbb->blk_list) < rbb->blk_max_num && new_rbb) |
8 tasks
Member
|
Fix it with #3279. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
改为最后才释放 rbb.
先释放 rbb 的话， rbb->buf 和 rbb->blk_set 的值可能会被篡改。
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up