Skip to content

feat(console): 增加控制台日志输出开关#11168

Open
wdfk-prog wants to merge 1 commit intoRT-Thread:masterfrom
wdfk-prog:log_out
Open

feat(console): 增加控制台日志输出开关#11168
wdfk-prog wants to merge 1 commit intoRT-Thread:masterfrom
wdfk-prog:log_out

Conversation

@wdfk-prog
Copy link
Contributor

@wdfk-prog wdfk-prog commented Feb 3, 2026 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

本 PR 增加一个全局控制台输出开关：

  • rt_kprintf / rt_kputs 输出前检查开关，关闭时直接丢弃输出

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：log_out
  • 设置PR number为 \ Set the PR number to：11168
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 log_out 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the log_out branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added the Kernel PR has src relate code label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/kservice.c

📊 Current Review Status (Last Updated: 2026-02-03 16:39 CST)

  • ⌛ GorrayLi Pending Review
  • ⌛ ReviewSun Pending Review
  • ⌛ hamburger-os Pending Review
  • ⌛ lianux-mm Pending Review
  • ⌛ wdfk-prog Pending Review
  • ⌛ xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@wdfk-prog
feat(console): Add console output enable switch
fb15bc7 
- rt_console_output_enabled()/rt_console_output_is_enabled() gate rt_kprintf/rt_kputs output with the switch
@wdfk-prog wdfk-prog changed the title feat(console): 增加控制台日志输出开关与 log_output 命令 feat(console): 增加控制台日志输出开关 Feb 3, 2026
@wdfk-prog
Copy link
Contributor Author

wdfk-prog commented Feb 4, 2026 

[cpp_check.py 80 INFO] src/kservice.c:433:5: error: Uninitialized variable: pc [uninitvar]
    RT_HW_BACKTRACE_FRAME_GET_SELF(&frame);
    ^
src/kservice.c:521:9: error: Uninitialized variable: pc [uninitvar]
        RT_HW_BACKTRACE_FRAME_GET_SELF(frame);
        ^
 
[cpp_check.py 111 ERROR] static code analysis(cppcheck) fail.
  • 此错误不是我代码导致

@BernardXiong
Copy link
Member

BernardXiong commented Feb 4, 2026

原来另外一种模式是，设置一个空的console device，然后就没log日志了

@wdfk-prog
Copy link
Contributor Author

wdfk-prog commented Feb 4, 2026

原来另外一种模式是，设置一个空的console device，然后就没log日志了

  • 可是我希望能有一种方式,实现说默认情况下关闭日志输出运行;等到需要调试或者排查时才打开日志输出
  • 如果将控制台设置为空设备,那么就无法接收处理了;或者说需要额外在实现接收处理

@BernardXiong
Copy link
Member

BernardXiong commented Feb 5, 2026

原来另外一种模式是，设置一个空的console device，然后就没log日志了

  • 可是我希望能有一种方式,实现说默认情况下关闭日志输出运行;等到需要调试或者排查时才打开日志输出
  • 如果将控制台设置为空设备,那么就无法接收处理了;或者说需要额外在实现接收处理

不需要日志时，是空的设备；需要日志时，给它设置一个可以输出的设备。不过在做设置切换时，需要做一定的处理

@wdfk-prog
Copy link
Contributor Author

wdfk-prog commented Feb 5, 2026

原来另外一种模式是，设置一个空的console device，然后就没log日志了

  • 可是我希望能有一种方式,实现说默认情况下关闭日志输出运行;等到需要调试或者排查时才打开日志输出
  • 如果将控制台设置为空设备,那么就无法接收处理了;或者说需要额外在实现接收处理

不需要日志时，是空的设备；需要日志时，给它设置一个可以输出的设备。不过在做设置切换时，需要做一定的处理

  • 是的,这么做是可以;但是需要额外的逻辑;
  • 直接能够设置控制台是否允许输出,看着是最简单的方案了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Kernel PR has src relate code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wdfk-prog @BernardXiong