[virtio] Fix queue_sel ordering in virtio_queue_init and virtio_queue_destroy #11114
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per VirtIO spec,
QueueSelmust be written before reading queue-specific registers likeQueueNumMax. The code was readingqueue_num_maxbefore settingqueue_sel, causing failures on ARM FVP.Changes
virtio_queue_init:
queue_selbefore readingqueue_num_max(moved from line 131 to 105)queue_num_max > queue_indexwithqueue_index < queues_numring_size <= queue_num_maxto validate against hardware limitsvirtio_queue_destroy:
queue_selbefore readingqueue_num_max(moved from line 170 to 163)queue_num_max > queue_indexwithqueue_index < queues_numOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.