[sdio][dm] update for DM by GuEe-GUI · Pull Request #11078 · RT-Thread/rt-thread

GuEe-GUI · 2025-12-22T05:44:37Z

拉取/合并请求描述：(PR description)

[

import Kconfig for DM.
fixup IRQ and mmcsd threads' stack size default.
support DM mode
1. Support features read by DM.
2. Support regulator API in drivers.
3. Support send tuning option CMD.
4. Replace switch_uhs_voltage by signal_voltage_switch.
cleanup the SDHCI
add new SDIO/SDHCI drivers
1. SDHCI support on PCI bus
2. Synopsys DesignWare MMC Family(MMIO/PCI)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Signed-off-by: GuEe-GUI <2991707448@qq.com>

1. Support features read by DM. 2. Support regulator API in drivers. 3. Support send tuning option CMD. 4. Replace `switch_uhs_voltage` by `signal_voltage_switch`. Signed-off-by: GuEe-GUI <2991707448@qq.com>

Signed-off-by: GuEe-GUI <2991707448@qq.com>

1. SDHCI support on PCI bus 2. Synopsys DesignWare MMC Family(MMIO/PCI) Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions · 2025-12-22T05:44:44Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：upstream
设置PR number为 \ Set the PR number to：11078

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 upstream 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the upstream branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-12-22T05:44:49Z

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)

components/drivers/include/drivers/dev_mmcsd_core.h
components/drivers/include/drivers/dev_sdhci.h
components/drivers/include/drivers/dev_sdhci_host.h
components/drivers/include/drivers/mmcsd_host.h
components/drivers/include/rtdevice.h
components/drivers/sdio/Kconfig
components/drivers/sdio/SConscript
components/drivers/sdio/dev_mmcsd_core.c
components/drivers/sdio/dev_regulator.c
components/drivers/sdio/dev_sd.c
components/drivers/sdio/dev_sdhci.c
components/drivers/sdio/dev_sdhci_dm.c
components/drivers/sdio/dev_sdhci_dm.h
components/drivers/sdio/dev_sdhci_host.c
components/drivers/sdio/dev_sdio_dm.c
components/drivers/sdio/dev_sdio_dm.h
components/drivers/sdio/host/Kconfig
components/drivers/sdio/host/SConscript
components/drivers/sdio/host/sdhci-pci.c
components/drivers/sdio/host/sdio-dw-pci.c
components/drivers/sdio/host/sdio-dw-platform.c
components/drivers/sdio/host/sdio-dw-platform.h
components/drivers/sdio/host/sdio-dw.c
components/drivers/sdio/host/sdio-dw.h
components/drivers/sdio/sdhci/include/sdhci-platform.h
components/drivers/sdio/sdhci/include/sdhci.h
components/drivers/sdio/sdhci/include/sdhci_host.h
components/drivers/sdio/sdhci/include/sdhci_misc.h

📊 Current Review Status (Last Updated: 2025-12-22 13:44 CST)

⌛ @Maihuanyi Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

GuEe-GUI · 2025-12-22T05:46:09Z

@helloeagleyang 可以来看看 bsp/hpmicro/libraries/drivers/drv_sdio.c 的修改。

components/drivers/sdio/dev_sd.c

helloeagleyang · 2025-12-22T06:56:10Z

@helloeagleyang 可以来看看 bsp/hpmicro/libraries/drivers/drv_sdio.c 的修改。

单纯从改动上看，没有啥问题

GuEe-GUI · 2025-12-22T10:06:43Z

@Rbb666

Copilot

Pull request overview

This PR updates the SDIO/SDHCI subsystem to support Device Manager (DM) mode, adds new drivers, and refactors existing code. The main changes include:

Cleanup of old SDHCI header files and reorganization of code structure
Introduction of DM support with new abstraction layers (dev_sdio_dm.c/h, dev_sdhci_dm.c/h)
Addition of new SDIO/SDHCI drivers: SDHCI-PCI, SDIO-DW (DesignWare MMC) for platform and PCI
API modernization: replacing switch_uhs_voltage with signal_voltage_switch and adding signal voltage support
New regulator API support for power management
Addition of tuning command support (mmcsd_send_tuning, mmcsd_send_abort_tuning)
Configuration updates with new Kconfig options and updated stack size defaults

Reviewed changes

Copilot reviewed 27 out of 29 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
components/drivers/sdio/sdhci/include/*.h	Removed old SDHCI headers (cleanup)
components/drivers/sdio/dev_sdio_dm.[ch]	New DM abstraction layer for SDIO
components/drivers/sdio/dev_sdhci_dm.[ch]	New DM abstraction layer for SDHCI
components/drivers/sdio/dev_sdhci_host.c	Refactored to use DM APIs and container_of pattern
components/drivers/sdio/host/*	New host drivers: sdio-dw, sdhci-pci
components/drivers/sdio/dev_regulator.c	New regulator support for voltage control
components/drivers/sdio/dev_mmcsd_core.c	Added voltage switch and tuning functions
components/drivers/sdio/dev_sd.c	Updated to use new signal_voltage_switch API
components/drivers/sdio/Kconfig	Updated with DM options and stack size defaults
components/drivers/sdio/SConscript	Reorganized build configuration
bsp/hpmicro/libraries/drivers/drv_sdio.c	Updated to use new signal_voltage_switch API

Rbb666 · 2025-12-23T08:39:41Z

存在一些cppcheck问题，作者确认下

GuEe-GUI · 2025-12-23T10:12:46Z

这块不涉及到我提交的代码，简短看了下，代码逻辑上是没有问题的，因为这个变量就是要由 mmcsd_read_sd_status 初始化的，后面的代码会判断 mmcsd_read_sd_status 的返回值，如果不是成功是不会继续访问 sd_status 的，mmcsd_read_sd_status 返回成功的话必然会初始化 sd_status，这里是静态检查工具无法识别这种复杂逻辑。

GuEe-GUI added 5 commits December 22, 2025 13:27

[sdio][dm] import Kconfig for DM

04dd187

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[sdio] fixup IRQ and mmcsd threads' stack size default

c01b44f

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[sdio][dm] Support DM mode

578968a

1. Support features read by DM. 2. Support regulator API in drivers. 3. Support send tuning option CMD. 4. Replace `switch_uhs_voltage` by `signal_voltage_switch`. Signed-off-by: GuEe-GUI <2991707448@qq.com>

[dm][sdhci] Cleanup the SDHCI

5fafb28

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[sdio][dm] add new SDIO/SDHCI drivers

50b61b9

1. SDHCI support on PCI bus 2. Synopsys DesignWare MMC Family(MMIO/PCI) Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions bot added BSP component: drivers/sdio Component component: drivers labels Dec 22, 2025

helloeagleyang reviewed Dec 22, 2025

View reviewed changes

components/drivers/sdio/dev_sd.c Show resolved Hide resolved

supperthomas requested a review from Copilot December 22, 2025 10:47

Copilot started reviewing on behalf of supperthomas December 22, 2025 10:48 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

Rbb666 approved these changes Dec 24, 2025

View reviewed changes

Rbb666 merged commit c6498b5 into RT-Thread:master Dec 26, 2025
66 of 67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sdio][dm] update for DM#11078

[sdio][dm] update for DM#11078
Rbb666 merged 5 commits intoRT-Thread:masterfrom
GuEe-GUI:upstream

GuEe-GUI commented Dec 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

GuEe-GUI commented Dec 22, 2025

Uh oh!

Uh oh!

helloeagleyang commented Dec 22, 2025

Uh oh!

GuEe-GUI commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Rbb666 commented Dec 23, 2025

Uh oh!

GuEe-GUI commented Dec 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

GuEe-GUI commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Dec 22, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Dec 22, 2025

📌 Code Review Assignment

🏷️ Tag: components

📊 Current Review Status (Last Updated: 2025-12-22 13:44 CST)

📝 Review Instructions

Uh oh!

GuEe-GUI commented Dec 22, 2025

Uh oh!

Uh oh!

helloeagleyang commented Dec 22, 2025

Uh oh!

GuEe-GUI commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Rbb666 commented Dec 23, 2025

Uh oh!

GuEe-GUI commented Dec 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GuEe-GUI commented Dec 22, 2025 •

edited

Loading