[dm][rtc] update rtc and new drivers#11033
Conversation
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
1. rtc_dev_set_name for RTC device init the name auto. 2. rtc_wkalarm_to_timestamp and rtc_timestamp_to_wkalarm for rt_rtc_wkalarm/time_t convert. Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-10 11:17 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull request overview
This PR adds Device Manager (DM) support and multiple new RTC drivers to RT-Thread, including DS1302, DS1307, Goldfish, HYM8563, PCF8523, PCF8563, PL031, and RX8010.
Key Changes:
- New DM helper API for RTC device naming and alarm conversion (
rtc_dm.c,rtc_dm.h) - Eight new RTC device drivers with I2C/SPI/MMIO interfaces
- Updated Kconfig to change alarm thread stack size default from 2048 to
IDLE_THREAD_STACK_SIZE
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| components/drivers/rtc/rtc_dm.h | Declares DM helper functions for RTC device naming and alarm/timestamp conversion |
| components/drivers/rtc/rtc_dm.c | Implements automatic RTC device naming and alarm conversion utilities |
| components/drivers/rtc/rtc-rx8010.c | Driver for Epson RX8010SJ I2C RTC with alarm support - has duplicate bit operation bug |
| components/drivers/rtc/rtc-pl031.c | Driver for ARM PL031 MMIO RTC - has pointer cast bug |
| components/drivers/rtc/rtc-pcf8563.c | Driver for Philips PCF8563/Epson RTC8564 I2C RTC with clock output |
| components/drivers/rtc/rtc-pcf8523.c | Driver for NXP PCF8523 I2C RTC |
| components/drivers/rtc/rtc-hym8563.c | Driver for Haoyu HYM8563 I2C RTC with clock output - has typo in error message |
| components/drivers/rtc/rtc-goldfish.c | Driver for Goldfish (Android emulator) RTC |
| components/drivers/rtc/rtc-ds1307.c | Driver for Dallas DS1307 family I2C RTCs |
| components/drivers/rtc/rtc-ds1302.c | Driver for Dallas DS1302 SPI RTC |
| components/drivers/rtc/SConscript | Build script updates to include new drivers based on Kconfig |
| components/drivers/rtc/Kconfig | Configuration options for new drivers - has wrong dependency for DS1307 |
1. Dallas/Maxim DS1302 2. Dallas/Maxim DS1307/37/38/39/40, ST M41T11 3. Goldfish Real Time Clock 4. Haoyu Microelectronics HYM8563 5. NXP PCF8523 6. Philips PCF8563/Epson RTC8564 7. ARM PL031 8. Epson RX8010SJ Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
@Rbb666 AI 相关要求已修改 |
* [dd][rtc] set the RTC alarm thread stack size default. Signed-off-by: GuEe-GUI <2991707448@qq.com> * [dm][rtc] make Kconfig import for DM Signed-off-by: GuEe-GUI <2991707448@qq.com> * [dm][rtc] support DM API for RTC 1. rtc_dev_set_name for RTC device init the name auto. 2. rtc_wkalarm_to_timestamp and rtc_timestamp_to_wkalarm for rt_rtc_wkalarm/time_t convert. Signed-off-by: GuEe-GUI <2991707448@qq.com> * [dm][rtc] add new drivers 1. Dallas/Maxim DS1302 2. Dallas/Maxim DS1307/37/38/39/40, ST M41T11 3. Goldfish Real Time Clock 4. Haoyu Microelectronics HYM8563 5. NXP PCF8523 6. Philips PCF8563/Epson RTC8564 7. ARM PL031 8. Epson RX8010SJ Signed-off-by: GuEe-GUI <2991707448@qq.com> --------- Signed-off-by: GuEe-GUI <2991707448@qq.com>
2 participants
拉取/合并请求描述：(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up