Skip to content

[utest]: Solve the address misalignment issue of atomic operations#11016

Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Tm-C-mT:smp_assigned_idle_cores_tc-AlignAddress
Dec 4, 2025
Merged

[utest]: Solve the address misalignment issue of atomic operations#11016
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Tm-C-mT:smp_assigned_idle_cores_tc-AlignAddress

Conversation

@Tm-C-mT
Copy link
Contributor

@Tm-C-mT Tm-C-mT commented Dec 3, 2025

In smp_assigned_idle_cores_tc, the finish_flag involves atomic operations and thus requires address alignment.

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

Solve the address misalignment issue of atomic operations

你的解决方案是什么 (what is your solution)

Align the address of finish_flag

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：smp_assigned_idle_cores_tc-AlignAddress
  • 设置PR number为 \ Set the PR number to：11016
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 smp_assigned_idle_cores_tc-AlignAddress 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the smp_assigned_idle_cores_tc-AlignAddress branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added the Kernel PR has src relate code label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/utest/smp/smp_assigned_idle_cores_tc.c

📊 Current Review Status (Last Updated: 2025-12-04 10:53 CST)

  • ⌛ GorrayLi Pending Review
  • ⌛ ReviewSun Pending Review
  • ⌛ hamburger-os Pending Review
  • ⌛ lianux-mm Pending Review
  • ⌛ wdfk-prog Pending Review
  • ⌛ xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Rbb666
Rbb666 reviewed Dec 3, 2025
View reviewed changes
src/utest/smp/smp_assigned_idle_cores_tc.c Outdated
static rt_thread_t threads[RT_CPUS_NR - 1];
static int tick = 0, finish_flag = 0;
static int tick = 0;
static __attribute__((aligned(sizeof(rt_ubase_t)))) int finish_flag = 0;
Copy link
Member

@Rbb666 Rbb666 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用rt_align合适些

Copy link
Contributor Author

@Tm-C-mT Tm-C-mT Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@Tm-C-mT
[utest]: Solve the address misalignment issue of atomic operations
2dfeec4 
In smp_assigned_idle_cores_tc, the finish_flag involves atomic operations
and thus requires address alignment.

Signed-off-by: Mengchen Teng <teng_mengchen@163.com>
@Tm-C-mT Tm-C-mT force-pushed the smp_assigned_idle_cores_tc-AlignAddress branch from 68c8b73 to 2dfeec4 Compare December 4, 2025 02:52
@Rbb666 Rbb666 merged commit dd19c0e into RT-Thread:master Dec 4, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

Assignees

No one assigned

Labels

Kernel PR has src relate code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tm-C-mT @Rbb666