-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Fix][BSP][Serial_V2] add Serial V2 buffer configuration via Kconfig #10594 #10602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📌 Code Review Assignment🏷️ Tag: bsp_stm32Reviewers: Liang1795 hamburger-os wdfk-prog Changed Files (Click to expand)
🏷️ Tag: bsp_stm32f103-blue-pillReviewers: Liang1795 Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-08-19 19:32 CST)
📝 Review Instructions
|
按照 #10600 中的建议进行了重新修改 |
还要生成 rtconfig.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
问题似乎不止在stm32f103-blue-pill中存在,我再进一步改一下 |
STM32中的大多数型号都存在该问题,在提交中一并修改了。 |
修改行数好像有点多了,可能需要说明一下。
因为存在该问题的型号比较多,所以行数看起来很多,实际上只是做了一些替换。 |
根据 导致 #10594 中错误的原因应该也在于: |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
stm32/stm32f103-blue-pill中存在编译错误(#10594)
经测试,发现STM32的大多数型号都存在该问题。
你的解决方案是什么 (what is your solution)
我尝试复现该issue,但只发生了前3个报错。(或许还需要更多细节?)
解决方法是在
bsp\stm32\stm32xxx\board\Kconfig
中,添加V2缓冲区相关配置。请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up