Skip to content

修复任务丢失,优化内核性能 #10352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

htl5241
Copy link
Contributor

@htl5241 htl5241 commented Jun 1, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

跑测试时不时丢任务。

你的解决方案是什么 (what is your solution)

优化代码

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the Kernel PR has src relate code label Jun 1, 2025
@htl5241
Copy link
Contributor Author

htl5241 commented Jun 1, 2025

test.zip
丢失任务测试的代码,用gcc编译出现的快,llvm-arm 出现的慢。

@@ -150,7 +149,7 @@ void rt_system_scheduler_init(void)
LOG_D("start scheduler: max priority 0x%02x",
RT_THREAD_PRIORITY_MAX);

for (offset = 0; offset < RT_THREAD_PRIORITY_MAX; offset ++)
for (offset = 0; offset < RT_THREAD_PRIORITY_MAX; offset++)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++操作,请在前面保持空格。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++操作,请在前面保持空格。

用 rt-thread 提供的 .clang-format 格式化的

@aozima
Copy link
Member

aozima commented Jun 1, 2025

具体bug的关键原因是什么?
修复原理是什么?
更新的话,建议只对关键代码做最小更新,代码格式整理请不要混在一起,确有格式整理的必要的话,建议分开独立的commit.
看到还是用master分支提的PR,那么再有新的PR建议用的新的分支,不然1个PR还没看完,又关了发个新的。
建议楼主不如从修复cmake开始,先把这个PR合并成功先。

@BernardXiong
Copy link
Member

建议分两个PR,一个是针对性能优化部分(任务丢失部分?还不清晰这个说的是什么),一个是针对代码格式调整部分;两个PR不混淆在一起。

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 1, 2025

建议分两个PR,一个是针对性能优化部分(任务丢失部分?还不清晰这个说的是什么),一个是针对代码格式调整部分;两个PR不混淆在一起。

        else
        {
            rt_sched_remove_thread(curr_thread);
            RT_SCHED_CTX(curr_thread).stat = RT_THREAD_RUNNING | (RT_SCHED_CTX(curr_thread).stat & ~RT_THREAD_STAT_MASK);
        }这段代码  有问题,gcc编译的无论-o0  -o2 都会丢失任务,我提供的测试文件,测试绝对会复现。而且这代码性能降低最低5%以上的性能。

@htl5241 htl5241 closed this by deleting the head repository Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kernel PR has src relate code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants